From: Richard Kennedy <richard@rsk.demon.co.uk>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] writeback: tracing and wbc->nr_to_write fixes
Date: Tue, 20 Apr 2010 13:02:16 +0100 [thread overview]
Message-ID: <4BCD97C8.6090406@rsk.demon.co.uk> (raw)
In-Reply-To: <1271731314-5893-1-git-send-email-david@fromorbit.com>
On 20/04/10 03:41, Dave Chinner wrote:
> This series contains the initial writeback tracing patches from
> Jens, as well as the extensions I added to provide visibility into
> writeback control structures as the are used by the writeback code.
> The visibility given is sufficient to understand what is happening
> in the writeback path - what path is writing data, what path is
> blocking on congestion, etc, and to determine the differences in
> behaviour for different sync modes and calling contexts. This
> tracing really needs to be integrated into mainline so that anyone
> can improve the tracing as they use it to track down problems
> in our convoluted writeback paths.
>
> The remaining patches are fixes to problems that the new tracing
> highlighted.
>
Hi Dave,
Thanks for adding tracing to this, it will be really useful.
The fix to write_cache_pages looks really interesting, I'm going to test
it on my machine. Maybe it should be a separate patch to get more
visibility?
Ext4 also multiplies nr_to_write, so will that need fixing too?
regards
Richard
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-20 12:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 2:41 [PATCH 0/4] writeback: tracing and wbc->nr_to_write fixes Dave Chinner
2010-04-20 2:41 ` [PATCH 1/4] writeback: initial tracing support Dave Chinner
2010-05-21 15:06 ` Christoph Hellwig
2010-04-20 2:41 ` [PATCH 2/4] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-04-20 2:41 ` [PATCH 3/4] writeback: pay attention to wbc->nr_to_write in write_cache_pages Dave Chinner
2010-04-22 19:07 ` Jan Kara
2010-04-25 3:33 ` tytso
2010-04-26 1:49 ` Dave Chinner
2010-04-26 2:43 ` tytso
2010-04-26 2:45 ` tytso
2010-04-27 3:30 ` Dave Chinner
2010-04-29 21:39 ` Andrew Morton
2010-04-30 6:01 ` Aneesh Kumar K. V
2010-04-30 19:43 ` Andrew Morton
2010-05-01 19:47 ` tytso
2010-04-20 2:41 ` [PATCH 4/4] xfs: remove nr_to_write writeback windup Dave Chinner
2010-04-22 19:09 ` Jan Kara
2010-04-26 0:46 ` Dave Chinner
2010-04-20 3:40 ` [PATCH 5/4] writeback: limit write_cache_pages integrity scanning to current EOF Dave Chinner
2010-04-20 23:28 ` Jamie Lokier
2010-04-20 23:31 ` Dave Chinner
2010-04-22 19:13 ` Jan Kara
2010-04-20 12:02 ` Richard Kennedy [this message]
2010-04-20 23:29 ` [PATCH 0/4] writeback: tracing and wbc->nr_to_write fixes Dave Chinner
2010-05-21 15:05 ` Christoph Hellwig
2010-05-22 0:09 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCD97C8.6090406@rsk.demon.co.uk \
--to=richard@rsk.demon.co.uk \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox