From: Eric Sandeen <sandeen@sandeen.net>
To: aelder@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfstests: use stat not lstat when examining devices
Date: Tue, 08 Jun 2010 11:06:23 -0500 [thread overview]
Message-ID: <4C0E6A7F.2060808@sandeen.net> (raw)
In-Reply-To: <1275676010.2317.53.camel@doink>
Alex Elder wrote:
> On Fri, 2010-06-04 at 13:00 -0500, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch
>> framework ultimately uses lstat not stat, and does not think
>> the lvm device (which is usually a symlink to a dm-X device)
>> is a block device. Sigh.
>>
>> Just calling stat(1) with -L to follow the link should
>> suffice.
>
> I wonder whether we'll find stat(1) output ever varies
> enough to affect this.
>
> But otherwise this looks good to me.
>
> Reviewed-by: Alex Elder <aelder@sgi.com>
>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Sorry, after all that I'm retracting this patch. mount, /proc/mounts,
/etc/mtab etc just get very confused when using symlinked devices,
at least as xfstests wants to use them.
For now I'll just make my uber-harness resolve symlinks to the real
device (maybe that could be done in xfstests at some point)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-08 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 15:27 [PATCH] xfstests: use stat not lstat when examining devices Eric Sandeen
2010-06-04 17:36 ` [PATCH V2] " Eric Sandeen
2010-06-04 18:00 ` [PATCH V3] " Eric Sandeen
2010-06-04 18:26 ` Alex Elder
2010-06-08 16:06 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0E6A7F.2060808@sandeen.net \
--to=sandeen@sandeen.net \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox