From: Eric Sandeen <sandeen@sandeen.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andi Kleen <ak@linux.intel.com>, Christoph Hellwig <hch@lst.de>,
dgc@fromorbit.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
Date: Tue, 15 Jun 2010 21:48:03 -0500 [thread overview]
Message-ID: <4C183B63.5090306@sandeen.net> (raw)
In-Reply-To: <20100614163122.GB369@basil.fritz.box>
Andi Kleen wrote:
> On Mon, Jun 14, 2010 at 03:39:58PM +0200, Andi Kleen wrote:
>> On Mon, Jun 14, 2010 at 02:48:04PM +0200, Christoph Hellwig wrote:
>>> On Mon, Jun 14, 2010 at 10:59:33AM +0200, Andi Kleen wrote:
>>>>> How can this work? bp->data is a void pointer.
>>>> It compiled with CONFIG_XFS_DEBUG enabled. Do I need to set some other
>>>> option to test this?
>>> It fails for me in a normal CONFIG_XFS_DEBUG build:
>>>
>>> fs/xfs/xfs_da_btree.c: In function 'xfs_da_root_join':
>>> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
>>> fs/xfs/xfs_da_btree.c:737: error: request for member 'magic' in
>>> something not a structure or union
>>> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
>>
>> Hmm, it really compiled here (scratching head)
>
> Never mind, it seems SUBDIRS doesn't set the DEBUG flag correctly.
really?
$ make SUBDIRS=fs/xfs
CC [M] fs/xfs/linux-2.6/xfs_super.o
fs/xfs/linux-2.6/xfs_super.c:73:2: error: #error DEBUG
make[1]: *** [fs/xfs/linux-2.6/xfs_super.o] Error 1
$ grep -A3 XFS_DEBUG fs/xfs/linux-2.6/xfs_super.c
#ifdef CONFIG_XFS_DEBUG
#error DEBUG
#endif
(above just for testing)
Offtopic I guess, but it sure seems to set it for me.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-16 2:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:13 [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2 Andi Kleen
2010-06-14 8:30 ` Christoph Hellwig
2010-06-14 8:59 ` Andi Kleen
2010-06-14 12:48 ` Christoph Hellwig
2010-06-14 13:39 ` Andi Kleen
2010-06-14 16:31 ` Andi Kleen
2010-06-15 0:54 ` Dave Chinner
2010-06-15 7:24 ` Andi Kleen
2010-06-16 2:48 ` Eric Sandeen [this message]
2010-06-16 7:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C183B63.5090306@sandeen.net \
--to=sandeen@sandeen.net \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dgc@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox