From: Andi Kleen <ak@linux.intel.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Andi Kleen <andi@firstfloor.org>, Christoph Hellwig <hch@lst.de>,
dgc@fromorbit.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
Date: Wed, 16 Jun 2010 09:33:42 +0200 [thread overview]
Message-ID: <4C187E56.70601@linux.intel.com> (raw)
In-Reply-To: <4C183B63.5090306@sandeen.net>
> really?
>
> $ make SUBDIRS=fs/xfs
> CC [M] fs/xfs/linux-2.6/xfs_super.o
> fs/xfs/linux-2.6/xfs_super.c:73:2: error: #error DEBUG
> make[1]: *** [fs/xfs/linux-2.6/xfs_super.o] Error 1
>
> $ grep -A3 XFS_DEBUG fs/xfs/linux-2.6/xfs_super.c
> #ifdef CONFIG_XFS_DEBUG
> #error DEBUG
> #endif
>
> (above just for testing)
>
> Offtopic I guess, but it sure seems to set it for me.
You did a full build with XFS_DEBUG before without SUBDIRS, right?
Kbuild puts the options into special .cmd files and I think
those only get rebuild on a full build, not on a SUBDIRS
build. So it never picked up the changed option for me.
Anyways that's the current theory, haven't retested that.
-Andi
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-16 7:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:13 [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2 Andi Kleen
2010-06-14 8:30 ` Christoph Hellwig
2010-06-14 8:59 ` Andi Kleen
2010-06-14 12:48 ` Christoph Hellwig
2010-06-14 13:39 ` Andi Kleen
2010-06-14 16:31 ` Andi Kleen
2010-06-15 0:54 ` Dave Chinner
2010-06-15 7:24 ` Andi Kleen
2010-06-16 2:48 ` Eric Sandeen
2010-06-16 7:33 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C187E56.70601@linux.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dgc@fromorbit.com \
--cc=hch@lst.de \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox