public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Linda Walsh <xfs@tlinx.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfs.fsck change that is unhelpful
Date: Sat, 14 Aug 2010 19:03:20 -0700	[thread overview]
Message-ID: <4C674AE8.7030107@tlinx.org> (raw)
In-Reply-To: <20100815005240.GH10429@dastard>



Dave Chinner wrote:
> On Sat, Aug 14, 2010 at 01:48:01PM -0700, Linda A. Walsh wrote:
>> Some time ago, when I upgraded a system, I ran into problems when
>> it hit a file system that was offline.  It wasn't a critical
>> partition, so it normally wouldn't have been an issue, but somewhere
>> along the line
>> someone mangled fsck.xfs.
> 
> fsck.xfs is behaving identically to e2fsck when presented with an
> invalid block device - it exits with an error of 8, which is defined
> as "operational error" in the e2fsck man page.
---
	That may be fine for the ext2 fs, but I am asserting that in actual
practice, with xfs, it does more harm than good.



> That sounds like a problem with the distro init scripts or you've
> stuffed up your /etc/fstab config (i.e. fs_passno is wrong). Indeed,
> setting fs_passno = 0 will cause the filesysetm fsck to be skipped
> completely on boot, regardless of the fs type...
---
	Yes, you are right.  They are setup to be check in the order
I would want them mounted.  But I don't see the benefit to being
compliant with a checking mechanism for a file system that is
actually needs fsck.

	It was long a *feature* of xfs, that xfs.fsck, was a noop.

	I don't see that making it fail in ways fsck does for a file
system that *needs* fsck, is productive.  Sure, it may be dotting i's
and crossing t's, but in reality, is that a standard xfs should be
living down to?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-08-15  2:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 20:48 xfs.fsck change that is unhelpful Linda A. Walsh
2010-08-15  0:52 ` Dave Chinner
2010-08-15  2:03   ` Linda Walsh [this message]
2010-08-15 18:54     ` Hans-Peter Jansen
2010-08-15 22:43     ` Matthias Schniedermeyer
2010-08-16  1:55     ` Dave Chinner
2010-08-16  2:26       ` Linda Walsh
2010-08-16  9:44         ` Stan Hoeppner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C674AE8.7030107@tlinx.org \
    --to=xfs@tlinx.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox