From: Eric Sandeen <sandeen@sandeen.net>
To: Mike Gao <ygao.linux@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: What should to do with ASSERT failed
Date: Mon, 30 Aug 2010 16:47:20 -0500 [thread overview]
Message-ID: <4C7C26E8.9070308@sandeen.net> (raw)
In-Reply-To: <AANLkTin-zf0chkk68pGfwDRt03QaKmNdsP3=goDEUS+p@mail.gmail.com>
Mike Gao wrote:
> xfs_vm_writepage
> {
> /*
> * A hole may still be marked uptodate because discard_buffer
> * leaves the flag set.
> */
> if (!buffer_mapped(bh) && buffer_uptodate(bh)) {
> ASSERT(!buffer_dirty(bh));
> imap_valid = 0;
> continue;
> }
> }
>
> I met this case that buffer is marked as dirty which make assert failed.
> What does this mean and what I can do with it?
You can report it here, with more information on what load you were running,
and the full backtrace that the ASSERT generated... thanks!
And it means that we think we are in a hole, but the buffer for
that hole is marked dirty, which we did not expect ...
The change went in with this commit:
3d9b02e3c76531687ab5314e0edf266256f13c2d xfs: fix corruption case for block size < page size
which was attempting to fix a very specific file corruption case.
What kernel are you running on?
What block size are you using? (xfs_info will tell you)
Thanks,
-Eric
> Thanks very much,
> Mike
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-08-30 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 20:55 What should to do with ASSERT failed Mike Gao
2010-08-30 21:47 ` Eric Sandeen [this message]
2010-08-30 22:56 ` Mike Gao
2010-08-30 23:30 ` Eric Sandeen
2010-08-30 23:32 ` Eric Sandeen
2010-08-31 0:30 ` Dave Chinner
2010-08-31 22:50 ` Mike Gao
2010-08-31 23:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7C26E8.9070308@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
--cc=ygao.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox