From: Alain Renaud <arenaud@sgi.com>
To: xfs@oss.sgi.com
Subject: [PATCH] xfstests: make 223 use more compatible indirection operator
Date: Fri, 01 Oct 2010 09:09:33 -0400 [thread overview]
Message-ID: <4CA5DD8D.3010200@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
Hello all,
I notice while running xfstests on SLES machine that the test 223 fail
because of syntax error.
# bash 223
QA output created by 223
223: line 66: syntax error near unexpected token `>'
223: line 66: ` _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE&>> $seq.full'
The error is due to the use of the '&>>' operator for redirection that does not
work on older bash version(3.2.x).
Note that this operator only seem to work with bash version 4.X+
This patch simply replace the operator with '>> $seq.full 2>&1' which does
the same thing.
--
Signed-off-by: Alain Renaud <arenaud@sgi.com>
[-- Attachment #2: 223.patch --]
[-- Type: text/x-patch, Size: 1561 bytes --]
Index: xfstests/223
===================================================================
--- xfstests/223.orig
+++ xfstests/223
@@ -63,7 +63,7 @@
let SUNIT_BLOCKS=$SUNIT_BYTES/$BLOCKSIZE
echo "=== mkfs with su $SUNIT_BLOCKS blocks x 4 ==="
- _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE &>> $seq.full
+ _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seq.full 2>&1
_scratch_mount
for SIZE_MULT in 1 2 8 64 256; do
@@ -73,10 +73,10 @@
for FILE in 1 2 3 4; do
xfs_io -F -f -c "falloc 0 $SIZE" \
$SCRATCH_MNT/file-$FILE-$SIZE-falloc \
- &>> $seq.full
+ >> $seq.full 2>&1
xfs_io -F -f -c "pwrite 0 $SIZE" \
$SCRATCH_MNT/file-$FILE-$SIZE-write \
- &>> $seq.full
+ >> $seq.full 2>&1
src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-falloc \
$SUNIT_BLOCKS | _filter_scratch
src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-write \
@@ -85,7 +85,8 @@
done
echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
- xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
+ xfs_io -F -f -c "falloc 0 1g" \
+ $SCRATCH_MNT/file-1g-falloc >> $seq.full 2>&1
src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
| _filter_scratch
@@ -93,7 +94,7 @@
echo "=== Testing size 1073745920 falloc on ${SUNIT_K}k stripe ==="
xfs_io -F -f -c "falloc 0 1073745920" \
- $SCRATCH_MNT/file-1073745920-falloc &>> $seq.full
+ $SCRATCH_MNT/file-1073745920-falloc >> $seq.full 2>&1
src/t_stripealign $SCRATCH_MNT/file-1073745920-falloc \
$SUNIT_BLOCKS | _filter_scratch
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-10-01 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 13:09 Alain Renaud [this message]
2010-10-02 1:58 ` [PATCH] xfstests: make 223 use more compatible indirection operator Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA5DD8D.3010200@sgi.com \
--to=arenaud@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox