[PATCH] xfstests: make 223 use more compatible indirection operator

[PATCH] xfstests: make 223 use more compatible indirection operator

[Alain Renaud]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hello all,

I notice while running xfstests on SLES machine that the test 223 fail
because of syntax error.

# bash 223
QA output created by 223
223: line 66: syntax error near unexpected token `>'
223: line 66: `    _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE&>>  $seq.full'

The error is due to the use of the '&>>' operator for redirection that does not
work  on older bash version(3.2.x).
Note that this operator only seem to work with bash version 4.X+

This patch simply replace the operator with '>>  $seq.full 2>&1' which does
the same thing.

--
Signed-off-by: Alain Renaud <arenaud@sgi.com>




[-- Attachment #2: 223.patch --]
[-- Type: text/x-patch, Size: 1561 bytes --]

Index: xfstests/223
===================================================================
--- xfstests/223.orig
+++ xfstests/223
@@ -63,7 +63,7 @@
 	let SUNIT_BLOCKS=$SUNIT_BYTES/$BLOCKSIZE
 
 	echo "=== mkfs with su $SUNIT_BLOCKS blocks x 4 ==="
-	_scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE &>> $seq.full
+	_scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seq.full 2>&1
 	_scratch_mount
 
 	for SIZE_MULT in 1 2 8 64 256; do
@@ -73,10 +73,10 @@
 		for FILE in 1 2 3 4; do
 			xfs_io -F -f -c "falloc 0 $SIZE" \
 				$SCRATCH_MNT/file-$FILE-$SIZE-falloc \
-					&>> $seq.full
+					>> $seq.full 2>&1
 			xfs_io -F -f -c "pwrite 0 $SIZE" \
 				$SCRATCH_MNT/file-$FILE-$SIZE-write \
-					&>> $seq.full
+					>> $seq.full 2>&1
 			src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-falloc \
 				$SUNIT_BLOCKS | _filter_scratch
 			src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-write \
@@ -85,7 +85,8 @@
 	done
 
 	echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
-	xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
+	xfs_io -F -f -c "falloc 0 1g" \
+	    $SCRATCH_MNT/file-1g-falloc >> $seq.full 2>&1
 	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
 	    | _filter_scratch
 
@@ -93,7 +94,7 @@
 
 	echo "=== Testing size 1073745920 falloc on ${SUNIT_K}k stripe ==="
 	xfs_io -F -f -c "falloc 0 1073745920" \
-		$SCRATCH_MNT/file-1073745920-falloc &>> $seq.full
+		$SCRATCH_MNT/file-1073745920-falloc >> $seq.full 2>&1
 	src/t_stripealign $SCRATCH_MNT/file-1073745920-falloc \
 		$SUNIT_BLOCKS | _filter_scratch
 


[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: make 223 use more compatible indirection operator

[Christoph Hellwig]

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs