From: Tejun Heo <tj@kernel.org>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Yang Ruirui <ruirui.r.yang@tieto.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Christoph Hellwig <hch@infradead.org>,
Alex Elder <aelder@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: -mm: xfs lockdep warning
Date: Mon, 04 Oct 2010 11:01:19 +0200 [thread overview]
Message-ID: <4CA997DF.5030008@kernel.org> (raw)
In-Reply-To: <AANLkTi=45J+=ytj=NC4bYTVJFRakNQQiFd35K7mrf+Gq@mail.gmail.com>
Hello,
On 09/25/2010 03:08 PM, Torsten Kaiser wrote:
> [adding Tejun Heo, because I'm partly blaming his workqueues]
:-) Sorry about the delay. I was away the last week.
> After that I enabled lockdep and retried the same update: This time no
> hang, only the same lockdep report that Yang Ruirui had.
>
> So I'm currently at a loss how I should continue from here. The XFS
> false positive drowns any other lockdep problems, but XFS had some
> hang problems with the new workqueues. (Personally I had no other hang
> with earlier 2.6.36-rcs)
If workqueue lockdep annotations are triggering spuriously, just nuke
all lockdep annotations in workqueue.c. Currently the annotations are
the same as before and trigger even when an actual deadlock won't
happen anymore around flushes (but then again all the current users
should be operating under the same constraints as before). I'm
looking into how to improve the lockdep annotations but in the end it
might be best to leave it as it is. I'll try to analyze the warnings.
Thanks.
--
tejun
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-04 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 7:46 -mm: xfs lockdep warning Yang Ruirui
2010-09-17 0:52 ` Dave Chinner
2010-09-20 19:13 ` Christoph Hellwig
2010-09-25 13:08 ` Torsten Kaiser
2010-10-04 9:01 ` Tejun Heo [this message]
2010-10-04 9:21 ` Dave Chinner
2010-10-05 10:09 ` Torsten Kaiser
2010-10-05 16:51 ` Tejun Heo
2010-10-05 16:55 ` Tejun Heo
2010-10-05 18:09 ` Torsten Kaiser
2010-10-05 18:17 ` Christoph Hellwig
2010-10-05 17:54 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA997DF.5030008@kernel.org \
--to=tj@kernel.org \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruirui.r.yang@tieto.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox