From: Bill Kendall <wkendall@sgi.com>
To: aelder@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfsrestore: turn off NODECHK
Date: Fri, 15 Oct 2010 09:07:31 -0500 [thread overview]
Message-ID: <4CB86023.3050906@sgi.com> (raw)
In-Reply-To: <1287081911.2362.574.camel@doink>
On 10/14/2010 01:45 PM, Alex Elder wrote:
> On Tue, 2010-10-12 at 16:53 -0500, wkendall@sgi.com wrote:
>> plain text document attachment (no_node_check)
>> The NODECHK macro should only be enabled as needed for
>> development/debugging. Having it on limits xfsrestore to
>> 268 million directory entries instead of 4 billion.
>
> I was going to suggest you leave it in the Makefile in
> commented-out form, perhaps with an explanation that
> it's available for development. But since NODECHK is
> only ever referenced inside "restore/node.c", maybe
> such a thing could be done inside that file instead.
>
> I.e., something like:
>
> /*
> * NODECHK can be enabled for development and debugging
> * in order to enforce additional checks on handles
> * when nodes are mapped, unmapped, and freed. It should
> * not be used for production code, it cuts into the number
> * of directory entries xfsrestore can handle.
> */
> /* #define NODECHK */
>
> I'll leave it up to you whether you think that's worth
> doing (and if so, let me know). Either way:
>
> Reviewed-by: Alex Elder<aelder@sgi.com>
Sounds like a good idea. I'll add something like this
and repost.
Bill
>
>> Signed-off-by: Bill Kendall<wkendall@sgi.com>
>>
>> Index: xfsdump-kernel.org/restore/Makefile
>> ===================================================================
>> --- xfsdump-kernel.org.orig/restore/Makefile
>> +++ xfsdump-kernel.org/restore/Makefile
>> @@ -103,7 +103,7 @@ LLDLIBS = $(LIBUUID) $(LIBHANDLE) $(LIBA
>> LTDEPENDENCIES = $(LIBRMT)
>>
>> LCFLAGS = -DRESTORE -DRMT -DBASED -DDOSOCKS -DINVCONVFIX -DPIPEINVFIX \
>> - -DEOMFIX -DSESSCPLT -DWHITEPARSE -DNODECHK -DDIRENTHDR_CHECKSUM \
>> + -DEOMFIX -DSESSCPLT -DWHITEPARSE -DDIRENTHDR_CHECKSUM \
>> -DF_FSSETDM
>>
>> default: depend $(LTCOMMAND)
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-15 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 21:53 [PATCH 0/2] xfsrestore: lift directory entry count limitations wkendall
2010-10-12 21:53 ` [PATCH 1/2] xfsrestore: turn off NODECHK wkendall
2010-10-14 18:45 ` Alex Elder
2010-10-15 14:07 ` Bill Kendall [this message]
2010-10-12 21:53 ` [PATCH 2/2] xfsrestore: change nrh_t to be 64 bits instead of 32 wkendall
2010-10-14 18:45 ` Alex Elder
2010-10-15 14:06 ` Bill Kendall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB86023.3050906@sgi.com \
--to=wkendall@sgi.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox