public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* no rw xfs file systems in mtab: /proc/mounts
@ 2010-12-23 12:32 Honza Fikar
  2010-12-23 15:02 ` Eric Sandeen
  0 siblings, 1 reply; 6+ messages in thread
From: Honza Fikar @ 2010-12-23 12:32 UTC (permalink / raw)
  To: xfs

Hi guys,

when I try "xfs_fsr -v -d" on my two computers, it says now:

no rw xfs file systems in mtab: /proc/mounts

while actually there is the LUKS encrypted root:
...
/dev/mapper/root / xfs
rw,noatime,attr2,inode64,logbufs=8,logbsize=256k,noquota 0 0
...

on the third computer it works as expected, there are two xfs file
systems, one of them LUKS encrypted:
...
/dev/root / xfs
rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,noquota 0 0
/dev/mapper/encrypted /home xfs
rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,sunit=512,swidth=1536,noquota
0 0
...

and it was working some time ago on all the three computers

distribution gentoo
xfsprogs 3.1.4, but I just tried git version and it's the same
kernel 2.6.32, on the third machine 2.6.35

Best regards,
Honza

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: no rw xfs file systems in mtab: /proc/mounts
  2010-12-23 12:32 no rw xfs file systems in mtab: /proc/mounts Honza Fikar
@ 2010-12-23 15:02 ` Eric Sandeen
  2010-12-23 17:18   ` Honza Fikar
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2010-12-23 15:02 UTC (permalink / raw)
  To: Honza Fikar; +Cc: xfs

On 12/23/10 6:32 AM, Honza Fikar wrote:
> Hi guys,
> 
> when I try "xfs_fsr -v -d" on my two computers, it says now:
> 
> no rw xfs file systems in mtab: /proc/mounts

hm that's a little confusing, what it means is it looked
in /proc/mounts and did not find anything, or so it thought.


As a result of:

89e4b5bd5615edc584a5111c86f12b4f89f8dd7d xfs_fsr: use /proc/mounts if available

What does your /proc/mounts show?

-Eric

> while actually there is the LUKS encrypted root:
> ...
> /dev/mapper/root / xfs
> rw,noatime,attr2,inode64,logbufs=8,logbsize=256k,noquota 0 0
> ...
> 
> on the third computer it works as expected, there are two xfs file
> systems, one of them LUKS encrypted:
> ...
> /dev/root / xfs
> rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,noquota 0 0
> /dev/mapper/encrypted /home xfs
> rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,sunit=512,swidth=1536,noquota
> 0 0
> ...
> 
> and it was working some time ago on all the three computers
> 
> distribution gentoo
> xfsprogs 3.1.4, but I just tried git version and it's the same
> kernel 2.6.32, on the third machine 2.6.35
> 
> Best regards,
> Honza
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: no rw xfs file systems in mtab: /proc/mounts
  2010-12-23 15:02 ` Eric Sandeen
@ 2010-12-23 17:18   ` Honza Fikar
  2010-12-29 13:09     ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: Honza Fikar @ 2010-12-23 17:18 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 1017 bytes --]

> hm that's a little confusing, what it means is it looked
> in /proc/mounts and did not find anything, or so it thought.

I agree that it's confusing, while there are xfs mounted rw in /proc/mounts

> As a result of:
> 
> 89e4b5bd5615edc584a5111c86f12b4f89f8dd7d xfs_fsr: use /proc/mounts if available

I "quickly and dirty" tried to use /etc/mtab instead, but the result is
the same. Even tried some old version (3.0.3), which uses mtab and it's
the same.


> What does your /proc/mounts show?

it shows the lines included in the original e-mail, just here it is
wrapped, i.e. for the not working case:

>> ...
>> /dev/mapper/root / xfs
>> rw,noatime,attr2,inode64,logbufs=8,logbsize=256k,noquota 0 0
>> ...

and for working case:

>> ...
>> /dev/root / xfs
>> rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,noquota 0 0
>> /dev/mapper/encrypted /home xfs
>> rw,noatime,attr2,delaylog,inode64,logbufs=8,logbsize=256k,sunit=512,swidth=1536,noquota
>> 0 0
>> ...

Honza


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: no rw xfs file systems in mtab: /proc/mounts
  2010-12-23 17:18   ` Honza Fikar
@ 2010-12-29 13:09     ` Christoph Hellwig
  2011-01-10 15:55       ` Honza Fikar
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2010-12-29 13:09 UTC (permalink / raw)
  To: Honza Fikar; +Cc: Eric Sandeen, xfs

Can you please apply the debug patch below and see what output fsr gives
with it?


Index: xfsprogs-dev/fsr/xfs_fsr.c
===================================================================
--- xfsprogs-dev.orig/fsr/xfs_fsr.c	2010-12-29 14:02:59.618003862 +0100
+++ xfsprogs-dev/fsr/xfs_fsr.c	2010-12-29 14:04:32.795004496 +0100
@@ -405,10 +405,16 @@ initallfs(char *mtab)
 	while ((mp = getmntent(fp))) {
 		int rw = 0;
 
-		if (strcmp(mp->mnt_type, MNTTYPE_XFS ) != 0 ||
-		    stat64(mp->mnt_fsname, &sb) == -1 ||
-		    !S_ISBLK(sb.st_mode))
+		if (strcmp(mp->mnt_type, MNTTYPE_XFS ) != 0)
 			continue;
+		if (stat64(mp->mnt_fsname, &sb) == -1) {
+			printf("fsr: cannot stat %s\n", mp->mnt_fsname);
+			continue;
+		}
+		if (!S_ISBLK(sb.st_mode)) {
+			printf("fsr: %s is not a block device\n", mp->mnt_fsname);
+			continue;
+		}
 
 		cp = strtok(mp->mnt_opts,",");
 		do {
@@ -416,8 +422,7 @@ initallfs(char *mtab)
 				rw++;
 		} while ((cp = strtok(NULL, ",")) != NULL);
 		if (rw == 0) {
-			if (dflag)
-				fsrprintf(_("Skipping %s: not mounted rw\n"),
+			printf(_("Skipping %s: not mounted rw\n"),
 					mp->mnt_fsname);
 			continue;
 		}

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: no rw xfs file systems in mtab: /proc/mounts
  2010-12-29 13:09     ` Christoph Hellwig
@ 2011-01-10 15:55       ` Honza Fikar
  2011-01-10 18:50         ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: Honza Fikar @ 2011-01-10 15:55 UTC (permalink / raw)
  Cc: Eric Sandeen, xfs


[-- Attachment #1.1: Type: text/plain, Size: 551 bytes --]

On 12/29/2010 02:09 PM, Christoph Hellwig wrote:
> Can you please apply the debug patch below and see what output fsr gives
> with it?

the output is:

#fsr/xfs_fsr -v -d
fsr: cannot stat /dev/mapper/root
no rw xfs file systems in mtab: /etc/mtab

/dev/mapper/root is really missing, even though mount shows:

/dev/mapper/root on / type xfs
(rw,noatime,attr2,inode64,logbufs=8,logbsize=256k,noquota)

maybe it gets lost during initrd?

easy and dirty fix is ln -s /dev/root /dev/mapper/root

but how to fix it for real?

Honza


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: no rw xfs file systems in mtab: /proc/mounts
  2011-01-10 15:55       ` Honza Fikar
@ 2011-01-10 18:50         ` Christoph Hellwig
  0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2011-01-10 18:50 UTC (permalink / raw)
  To: Honza Fikar; +Cc: Eric Sandeen, xfs

On Mon, Jan 10, 2011 at 04:55:02PM +0100, Honza Fikar wrote:
> On 12/29/2010 02:09 PM, Christoph Hellwig wrote:
> > Can you please apply the debug patch below and see what output fsr gives
> > with it?
> 
> the output is:
> 
> #fsr/xfs_fsr -v -d
> fsr: cannot stat /dev/mapper/root
> no rw xfs file systems in mtab: /etc/mtab
> 
> /dev/mapper/root is really missing, even though mount shows:
> 
> /dev/mapper/root on / type xfs
> (rw,noatime,attr2,inode64,logbufs=8,logbsize=256k,noquota)
> 
> maybe it gets lost during initrd?
> 
> easy and dirty fix is ln -s /dev/root /dev/mapper/root

There's no easy way for xfs to work around the fact that a device
listed in /proc/mounts doesn't exist.

This might be a fallout of the big dm naming mess that happened due
to udev's insistance to be the only authority for device names.

I'd recommend to report a bug to your distribution about the
missing device name.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-01-10 18:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23 12:32 no rw xfs file systems in mtab: /proc/mounts Honza Fikar
2010-12-23 15:02 ` Eric Sandeen
2010-12-23 17:18   ` Honza Fikar
2010-12-29 13:09     ` Christoph Hellwig
2011-01-10 15:55       ` Honza Fikar
2011-01-10 18:50         ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox