Re: [PATCH] xfstests: Notify via syslog when godown is shutting down fs

Chandra Seetharaman
2011-02-17T17:28:03Z

Thanks Eric. This makes it clear that it is intentional.

chandra
On Wed, 2011-02-16 at 16:53 -0600, Eric Sandeen wrote:
> Just a hint for those perusing logs that the ensuing shutdown is
> intentional...
>
> Feb 16 17:06:17 hostname godown: xfstests-induced forced shutdown of /mnt/scratch
> Feb 16 17:06:17 hostname kernel: Filesystem "sdb3": xfs_log_force: error 5 returned.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/src/godown.c b/src/godown.c
> index 07b6980..b140a41 100644
> --- a/src/godown.c
> +++ b/src/godown.c
> @@ -16,6 +16,7 @@
> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> +#include <syslog.h>
> #include "global.h"
>
> static char *xprogname;
> @@ -109,6 +110,8 @@ main(int argc, char *argv[])
> if (verbose_opt) {
> printf("Calling XFS_IOC_GOINGDOWN\n");
> }
> + syslog(LOG_WARNING, "xfstests-induced forced shutdown of %s:\n",
> + mnt_dir);
> if ((xfsctl(mnt_dir, fd, XFS_IOC_GOINGDOWN, &flag)) == -1) {
> fprintf(stderr, "%s: error on xfsctl(GOINGDOWN) of \"%s\": %s\n",
> xprogname, mnt_dir, strerror(errno));
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs