From: Jeffrey Hundstad <jeffrey.hundstad@mnsu.edu>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Dan Rosenberg <drosenberg@vsecurity.com>,
xfs@oss.sgi.com, Eugene Teo <eugeneteo@kernel.org>,
aelder@sgi.com
Subject: Re: [PATCH, V3 (sort of)] xfs: zero proper structure size for geometry calls
Date: Tue, 01 Mar 2011 15:40:50 -0600 [thread overview]
Message-ID: <4D6D67E2.80503@mnsu.edu> (raw)
In-Reply-To: <4D6D3891.5060908@sandeen.net>
On 03/01/2011 12:18 PM, Eric Sandeen wrote:
> On 3/1/11 11:50 AM, Alex Elder wrote:
>
>> I'm sorry to muddy the waters with this. But I think the
>> proposed patch fixes the wrong problem. Having xfs_fs_geometry()
>> zero its argument is fine--it defines an interface and honors
>> it. The real problem lies in xfs_ioc_fsgeometry_v1(), which
>> violates that interface by passing the address of an object
>> that's not the right size. So below is an alternative to
>> Eric's solution which just fixes this one caller instead.
>>
>> Eric has already told me this makes more sense. It would
>> be nice if Jeffrey would re-test this fix, and Dan would
>> sign off on it as well.
>>
> Reviewed-by: Eric Sandeen<sandeen@redhat.com>
I can't tell you if the security concerns are met but I can tell you
that xfs_fsr is working as one would expect without a Kernel panic.
Tested-by: Jeffrey Hundstad <jeffrey.hundstad@mnsu.edu>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-01 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 22:58 kernel panic - stack-protector: kernel stack is corrupted in: f87aca93 Jeffrey Hundstad
2011-03-01 0:00 ` Eric Sandeen
2011-03-01 1:03 ` Jeffrey Hundstad
2011-03-01 1:32 ` Eric Sandeen
2011-03-01 2:57 ` Dave Chinner
2011-03-01 1:37 ` [PATCH] xfs: zero proper structure size for geometry calls Eric Sandeen
2011-03-01 2:59 ` Dave Chinner
2011-03-01 3:01 ` Eric Sandeen
2011-03-01 6:59 ` [PATCH V2] " Eric Sandeen
2011-03-01 12:55 ` Dan Rosenberg
2011-03-01 15:36 ` Jeffrey Hundstad
2011-03-01 15:49 ` Eric Sandeen
2011-03-01 17:50 ` [PATCH, V3 (sort of)] " Alex Elder
2011-03-01 18:18 ` Eric Sandeen
2011-03-01 21:40 ` Jeffrey Hundstad [this message]
2011-03-02 0:02 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D67E2.80503@mnsu.edu \
--to=jeffrey.hundstad@mnsu.edu \
--cc=aelder@sgi.com \
--cc=drosenberg@vsecurity.com \
--cc=eugeneteo@kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox