From: Eric Sandeen <sandeen@sandeen.net>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: make 127 and 134 clean up after themselves
Date: Wed, 09 Mar 2011 11:30:23 -0600 [thread overview]
Message-ID: <4D77B92F.9020008@sandeen.net> (raw)
In-Reply-To: <201103042022.p24KMAss008218@stout.americas.sgi.com>
On 3/4/11 2:22 PM, Alex Elder wrote:
> Tests 127 and 134 leave temp files around when they complete.
> Fix (or enable) their cleanup functions to remedy this.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Weird, 134 had the trap commented out from the initial commit...
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 127 | 1 +
> 134 | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/127
> ===================================================================
> --- a/127
> +++ b/127
> @@ -38,6 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 1
>
> _cleanup()
> {
> + rm -f $tmp.output
> _cleanup_testdir
> }
>
> Index: b/134
> ===================================================================
> --- a/134
> +++ b/134
> @@ -43,8 +43,7 @@ _cleanup()
> umount $SCRATCH_MNT 2>/dev/null
> rm -f $tmp.*
> }
> -#trap "_cleanup; exit \$status" 0 1 2 3 15
> -
> +trap "_cleanup; exit \$status" 0 1 2 3 15
>
> # real QA test starts here
> _supported_fs xfs
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-09 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 20:22 [PATCH] xfstests: make 127 and 134 clean up after themselves Alex Elder
2011-03-09 17:30 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77B92F.9020008@sandeen.net \
--to=sandeen@sandeen.net \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox