From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsqa: reduce error output on 229
Date: Thu, 14 Apr 2011 22:51:06 -0500 [thread overview]
Message-ID: <4DA7C0AA.3040104@sandeen.net> (raw)
In-Reply-To: <1302838310-28095-1-git-send-email-david@fromorbit.com>
On 4/14/11 10:31 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Once we get one short write, we know the test has failed. We don't
> ened to keep writing and getting more short writes and spewing
> thousands of errors to the console.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> src/t_holes.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/t_holes.c b/src/t_holes.c
> index eba310a..b111baf 100644
> --- a/src/t_holes.c
> +++ b/src/t_holes.c
> @@ -29,8 +29,10 @@ int main(int argc, char **argv)
> for (j = 0; j < 1024; j++)
> buf[j] = i | i << 5;
>
> - if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int))
> + if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int)) {
> printf("Write did not return correct amount\n");
> + exit(EXIT_FAILURE);
> + }
>
> if ((i % 9) == 0 && i < 9001)
> lseek(fd, 4096 * 110,SEEK_CUR);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-15 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 3:31 [PATCH] xfsqa: reduce error output on 229 Dave Chinner
2011-04-15 3:51 ` Eric Sandeen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-15 18:14 Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA7C0AA.3040104@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox