* [PATCH] xfsqa: reduce error output on 229
@ 2011-04-15 3:31 Dave Chinner
2011-04-15 3:51 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2011-04-15 3:31 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
Once we get one short write, we know the test has failed. We don't
ened to keep writing and getting more short writes and spewing
thousands of errors to the console.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
src/t_holes.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/t_holes.c b/src/t_holes.c
index eba310a..b111baf 100644
--- a/src/t_holes.c
+++ b/src/t_holes.c
@@ -29,8 +29,10 @@ int main(int argc, char **argv)
for (j = 0; j < 1024; j++)
buf[j] = i | i << 5;
- if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int))
+ if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int)) {
printf("Write did not return correct amount\n");
+ exit(EXIT_FAILURE);
+ }
if ((i % 9) == 0 && i < 9001)
lseek(fd, 4096 * 110,SEEK_CUR);
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfsqa: reduce error output on 229
2011-04-15 3:31 [PATCH] xfsqa: reduce error output on 229 Dave Chinner
@ 2011-04-15 3:51 ` Eric Sandeen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2011-04-15 3:51 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On 4/14/11 10:31 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Once we get one short write, we know the test has failed. We don't
> ened to keep writing and getting more short writes and spewing
> thousands of errors to the console.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> src/t_holes.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/t_holes.c b/src/t_holes.c
> index eba310a..b111baf 100644
> --- a/src/t_holes.c
> +++ b/src/t_holes.c
> @@ -29,8 +29,10 @@ int main(int argc, char **argv)
> for (j = 0; j < 1024; j++)
> buf[j] = i | i << 5;
>
> - if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int))
> + if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int)) {
> printf("Write did not return correct amount\n");
> + exit(EXIT_FAILURE);
> + }
>
> if ((i % 9) == 0 && i < 9001)
> lseek(fd, 4096 * 110,SEEK_CUR);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xfsqa: reduce error output on 229
@ 2011-04-15 18:14 Josef Bacik
0 siblings, 0 replies; 3+ messages in thread
From: Josef Bacik @ 2011-04-15 18:14 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
Once we get one short write, we know the test has failed. We don't
ened to keep writing and getting more short writes and spewing
thousands of errors to the console.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
---
src/t_holes.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/t_holes.c b/src/t_holes.c
index eba310a..4424335 100644
--- a/src/t_holes.c
+++ b/src/t_holes.c
@@ -14,10 +14,11 @@
* along with this program; if not, write the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <stdio.h>
+#include <stdlib.h>
#include <unistd.h>
#include <fcntl.h>
#include <sys/types.h>
-#include <stdio.h>
int main(int argc, char **argv)
{
@@ -29,8 +30,10 @@ int main(int argc, char **argv)
for (j = 0; j < 1024; j++)
buf[j] = i | i << 5;
- if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int))
+ if (write(fd,buf,253*4*sizeof(int))!= 253*4*sizeof(int)) {
printf("Write did not return correct amount\n");
+ exit(EXIT_FAILURE);
+ }
if ((i % 9) == 0 && i < 9001)
lseek(fd, 4096 * 110,SEEK_CUR);
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-15 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 3:31 [PATCH] xfsqa: reduce error output on 229 Dave Chinner
2011-04-15 3:51 ` Eric Sandeen
-- strict thread matches above, loose matches on Subject: below --
2011-04-15 18:14 Josef Bacik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox