* xfs build warning
@ 2011-04-15 16:48 Randy Dunlap
2011-04-15 17:39 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2011-04-15 16:48 UTC (permalink / raw)
To: xfs; +Cc: Christoph Hellwig
on i386, when CONFIG_LBDAF is not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
--
~Randy
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfs build warning
2011-04-15 16:48 xfs build warning Randy Dunlap
@ 2011-04-15 17:39 ` Christoph Hellwig
2011-04-15 17:47 ` Randy Dunlap
2011-04-21 20:08 ` Alex Elder
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2011-04-15 17:39 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Christoph Hellwig, xfs
On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
> on i386, when CONFIG_LBDAF is not enabled:
>
> fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
This should fix it:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_trace.h
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:29:11.569340965 +0200
+++ linux-2.6/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:30:09.679026159 +0200
@@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
__entry->wasfromfl,
__entry->isfl,
__entry->userdata,
- __entry->firstblock)
+ (unsigned long long)__entry->firstblock)
)
#define DEFINE_ALLOC_EVENT(name) \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfs build warning
2011-04-15 17:39 ` Christoph Hellwig
@ 2011-04-15 17:47 ` Randy Dunlap
2011-04-21 20:08 ` Alex Elder
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-04-15 17:47 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On 04/15/11 10:39, Christoph Hellwig wrote:
> On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
>> on i386, when CONFIG_LBDAF is not enabled:
>>
>> fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
>
> This should fix it:
>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:29:11.569340965 +0200
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:30:09.679026159 +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
> __entry->wasfromfl,
> __entry->isfl,
> __entry->userdata,
> - __entry->firstblock)
> + (unsigned long long)__entry->firstblock)
> )
>
> #define DEFINE_ALLOC_EVENT(name) \
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
--
~Randy
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfs build warning
2011-04-15 17:39 ` Christoph Hellwig
2011-04-15 17:47 ` Randy Dunlap
@ 2011-04-21 20:08 ` Alex Elder
2011-04-22 4:14 ` Christoph Hellwig
1 sibling, 1 reply; 5+ messages in thread
From: Alex Elder @ 2011-04-21 20:08 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Randy Dunlap, xfs
On Fri, 2011-04-15 at 13:39 -0400, Christoph Hellwig wrote:
> On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
> > on i386, when CONFIG_LBDAF is not enabled:
> >
> > fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
>
> This should fix it:
Looks good. Christoph, can I assume your signoff?
I wonder whether we'll ever need to cast the other
fields that are based on abstractions from __uint32_t
(like xfs_agblock_t, xfs_extlen_t, ...).
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfs build warning
2011-04-21 20:08 ` Alex Elder
@ 2011-04-22 4:14 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2011-04-22 4:14 UTC (permalink / raw)
To: Alex Elder; +Cc: Christoph Hellwig, Randy Dunlap, xfs
On Thu, Apr 21, 2011 at 03:08:10PM -0500, Alex Elder wrote:
> On Fri, 2011-04-15 at 13:39 -0400, Christoph Hellwig wrote:
> > On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
> > > on i386, when CONFIG_LBDAF is not enabled:
> > >
> > > fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
> >
> > This should fix it:
>
> Looks good. Christoph, can I assume your signoff?
>
> I wonder whether we'll ever need to cast the other
> fields that are based on abstractions from __uint32_t
> (like xfs_agblock_t, xfs_extlen_t, ...).
I'll resend it with a proper changelog and signoff.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-22 4:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 16:48 xfs build warning Randy Dunlap
2011-04-15 17:39 ` Christoph Hellwig
2011-04-15 17:47 ` Randy Dunlap
2011-04-21 20:08 ` Alex Elder
2011-04-22 4:14 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox