From: Eric Sandeen <sandeen@redhat.com>
To: sekharan@us.ibm.com
Cc: XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049
Date: Fri, 10 Jun 2011 17:12:22 -0500 [thread overview]
Message-ID: <4DF296C6.2090606@redhat.com> (raw)
In-Reply-To: <1307737668.7661.438.camel@chandra-lucid.beaverton.ibm.com>
On 6/10/11 3:27 PM, Chandra Seetharaman wrote:
> Test 049 depends on ext2 module being supported by the kernel.
>
> This patch makes it a explicit, instead of failing the test with
> obscure message.
>
> Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>
committed in the xfstests-dev tree on kernel.org, thanks!
-Eric
> ---
>
> diff --git a/049 b/049
> index 3d3f030..c6c4faa 100755
> --- a/049
> +++ b/049
> @@ -64,6 +64,7 @@ _require_nobigloopfs
> _require_nonexternal
> _require_scratch
> _require_loop
> +_require_ext2
>
> rm -f $seq.full
>
> diff --git a/common.rc b/common.rc
> index c510c66..44c746d 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -769,6 +769,24 @@ _require_loop()
> fi
> }
>
> +# this test requires ext2 filesystem support
> +#
> +_require_ext2()
> +{
> + if [ "$HOSTOS" != "Linux" ]
> + then
> + _notrun "This test requires linux for ext2 filesystem support"
> + fi
> +
> + modprobe ext2 >/dev/null 2>&1
> + if grep ext2 /proc/filesystems >/dev/null 2>&1
> + then
> + :
> + else
> + _notrun "This test requires ext2 filesystem support"
> + fi
> +}
> +
> # this test requires that (large) loopback device files are not in use
> #
> _require_nobigloopfs()
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-06-10 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 20:27 [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049 Chandra Seetharaman
2011-06-10 22:12 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF296C6.2090606@redhat.com \
--to=sandeen@redhat.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox