From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	p5AMCPkV012890 for <xfs@oss.sgi.com>; Fri, 10 Jun 2011 17:12:25 -0500
Received: from mx1.redhat.com (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 1D35D4BA54A
	for <xfs@oss.sgi.com>; Fri, 10 Jun 2011 15:12:24 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
	cuda.sgi.com with ESMTP id xoXfdy7WPwsvIqes for
	<xfs@oss.sgi.com>; Fri, 10 Jun 2011 15:12:24 -0700 (PDT)
Message-ID: <4DF296C6.2090606@redhat.com>
Date: Fri, 10 Jun 2011 17:12:22 -0500
From: Eric Sandeen <sandeen@redhat.com>
MIME-Version: 1.0
Subject: Re: [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test
	049
References: <1307737668.7661.438.camel@chandra-lucid.beaverton.ibm.com>
In-Reply-To: <1307737668.7661.438.camel@chandra-lucid.beaverton.ibm.com>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: sekharan@us.ibm.com
Cc: XFS Mailing List <xfs@oss.sgi.com>

On 6/10/11 3:27 PM, Chandra Seetharaman wrote:
> Test 049 depends on ext2 module being supported by the kernel.
> 
> This patch makes it a explicit, instead of failing the test with
> obscure message.
> 
> Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>

committed in the xfstests-dev tree on kernel.org, thanks!

-Eric

> ---
> 
> diff --git a/049 b/049
> index 3d3f030..c6c4faa 100755
> --- a/049
> +++ b/049
> @@ -64,6 +64,7 @@ _require_nobigloopfs
>  _require_nonexternal
>  _require_scratch
>  _require_loop
> +_require_ext2
>  
>  rm -f $seq.full
>  
> diff --git a/common.rc b/common.rc
> index c510c66..44c746d 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -769,6 +769,24 @@ _require_loop()
>      fi
>  }
>  
> +# this test requires ext2 filesystem support
> +#
> +_require_ext2()
> +{
> +    if [ "$HOSTOS" != "Linux" ]
> +    then
> +	_notrun "This test requires linux for ext2 filesystem support"
> +    fi
> +
> +    modprobe ext2 >/dev/null 2>&1
> +    if grep ext2 /proc/filesystems >/dev/null 2>&1
> +    then
> +	:
> +    else
> +	_notrun "This test requires ext2 filesystem support"
> +    fi
> +}
> +
>  # this test requires that (large) loopback device files are not in use
>  #
>  _require_nobigloopfs()
> 
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs