Re: [PATCH 2/3 v5] XFS TESTS: Expand 252 punch hole test

Christoph Hellwig
2011-06-17T12:08:56Z

On Mon, Jun 06, 2011 at 04:33:50PM -0700, Allison Henderson wrote:
> This patch adds additional punch hole tests to 252
> that were used to test ext4 punch hole. The _test_generic_punch
> routine has been modified to accept two new flags:
>
> -k To keep the test file between tests.
> This will test the handling of existing holes
>
> -d To not sync the file between tests.
> This will test the handling of delayed extents
>
> Four new corner cases have also been added to the routine:
> 14. data -> hole @ EOF
> 15. data -> hole @ 0
> 16. data -> cache cold ->hole
> 17. data -> hole in single block file

Looks good, I'll put it in.