From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73C7ulp151853 for ; Wed, 3 Aug 2011 07:07:56 -0500 Message-ID: <4E393A18.1050607@sgi.com> Date: Wed, 03 Aug 2011 07:07:52 -0500 From: Bill Kendall MIME-Version: 1.0 Subject: Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API References: <1311972011-1446-1-git-send-email-wkendall@sgi.com> <20110803105911.GA7226@infradead.org> <4E3937B1.7050207@sgi.com> <20110803120245.GA25335@infradead.org> In-Reply-To: <20110803120245.GA25335@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com Christoph Hellwig wrote: > On Wed, Aug 03, 2011 at 06:57:37AM -0500, Bill Kendall wrote: >> Christoph Hellwig wrote: >>> Bill, >>> >>> one thing I noticed looking over the code to understand your changes >>> is that there still is a lot of dead code in xfsdump. One that >>> has a lot of implications and seems fairly useless for any non-IRIX >>> version is the miniroot mode. Any chance we can rip that out? There's >> Yes, that's being used to disable multi-stream code in the Linux version. >> The end of my multi-stream patch series removes the miniroot code. > > Ooops, I didn't notice miniroot is actually defined to true. Now that > I look deeper that also answers my comment about the duplicate signal > setup in main - one it's done for the miniroot case, and once for the > !miniroot case. > > Now that we uses EPIPE instead of SIGPIPE is there actually any good > reason to do this setup in two different places? Nope, I'll resubmit with this change. Bill _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs