From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8JLVcBl015888 for ; Mon, 19 Sep 2011 16:31:38 -0500 Message-ID: <4E77B4B6.4080102@sgi.com> Date: Mon, 19 Sep 2011 16:31:34 -0500 From: Bill Kendall MIME-Version: 1.0 Subject: Re: [PATCH] xfsdump: remove redundant error code mapping References: <1314973338-20520-1-git-send-email-wkendall@sgi.com> <1316466127.2941.80.camel@doink> In-Reply-To: <1316466127.2941.80.camel@doink> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: aelder@sgi.com Cc: xfs@oss.sgi.com On 09/19/2011 04:02 PM, Alex Elder wrote: > On Fri, 2011-09-02 at 09:22 -0500, Bill Kendall wrote: >> Currently there is both an exit_strings array and an exit_codestring() >> function for mapping an exit code to a string. They are very similar >> except the latter prefaces every string with "EXIT_" and the former >> uses "SUCCESS" instead of "NORMAL", and cannot handle an invalid exit >> code. exit_codestring() is not currently used in active code (it's for >> multi-stream), so its values can be changed to allow the exit_strings >> array to be removed. > > Looks good. You need to add your signoff on these things, i.e.: > Signed-off-by: Bill Kendall > We follow the signoff process used in the Linux kernel. See > sections 12-14 in this document: > https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches > > > Reviewed-by: Alex Elder > Sorry, forgot the --signoff when formatting the patch. Need me to resubmit? Bill _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs