From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8KEA1af064694 for ; Tue, 20 Sep 2011 09:10:02 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E30DD175224 for ; Tue, 20 Sep 2011 07:10:00 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id lqz6ehmIJzLFffHM for ; Tue, 20 Sep 2011 07:10:00 -0700 (PDT) Message-ID: <4E789EA2.8070709@redhat.com> Date: Tue, 20 Sep 2011 10:09:38 -0400 From: Josef Bacik MIME-Version: 1.0 Subject: Re: [patch 4/4] Btrfs: pass __GFP_WRITE for buffered write page allocations References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-5-git-send-email-jweiner@redhat.com> <20110920135631.GB16338@redhat.com> In-Reply-To: <20110920135631.GB16338@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Johannes Weiner Cc: Rik van Riel , linux-ext4@vger.kernel.org, Jan Kara , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Christoph Hellwig , linux-mm@kvack.org, Andreas Dilger , Mel Gorman , linux-fsdevel@vger.kernel.org, Theodore Ts'o , Andrew Morton , Wu Fengguang , Chris Mason , Minchan Kim On 09/20/2011 09:56 AM, Johannes Weiner wrote: > On Tue, Sep 20, 2011 at 03:45:15PM +0200, Johannes Weiner wrote: >> Tell the page allocator that pages allocated for a buffered write are >> expected to become dirty soon. >> >> Signed-off-by: Johannes Weiner >> --- >> fs/btrfs/file.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c >> index e7872e4..ea1b892 100644 >> --- a/fs/btrfs/file.c >> +++ b/fs/btrfs/file.c >> @@ -1084,7 +1084,7 @@ static noinline int prepare_pages(struct btrfs_root *root, struct file *file, >> again: >> for (i = 0; i < num_pages; i++) { >> pages[i] = find_or_create_page(inode->i_mapping, index + i, >> - GFP_NOFS); >> + GFP_NOFS | __GFP_WRITE); > > Btw and unrelated to this particular series, I think this should use > grab_cache_page_write_begin() in the first place. > > Most grab_cache_page calls were replaced recently (a94733d "Btrfs: use > find_or_create_page instead of grab_cache_page") to be able to pass > GFP_NOFS, but the pages are now also no longer __GFP_HIGHMEM and > __GFP_MOVABLE, which irks both x86_32 and memory hotplug. > > It might be better to change grab_cache_page instead to take a flags > argument that allows passing AOP_FLAG_NOFS and revert the sites back > to this helper? So I can do pages[i] = grab_cache_page_write_begin(inode->i_mapping, index + i, AOP_FLAG_NOFS); right? All we need is nofs, so I can just go through and change everybody to that. I'd rather not have to go through and change grab_cache_page() to take a flags argument and change all the callers, I have a bad habit of screwing stuff like that up :). Thanks, Josef _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs