From: Eric Sandeen <sandeen@redhat.com>
To: aelder@sgi.com
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: test timestamps before the epoch
Date: Mon, 26 Sep 2011 11:02:05 -0500 [thread overview]
Message-ID: <4E80A1FD.8070400@redhat.com> (raw)
In-Reply-To: <1317040069.3030.18.camel@doink>
On 9/26/11 7:27 AM, Alex Elder wrote:
> On Mon, 2011-09-26 at 07:27 -0400, Christoph Hellwig wrote:
>> This one actually ends up failing on XFS for me:
>>
>> @@ -1,5 +1,5 @@
>> QA output created by 258
>> Creating file with timestamp of Jan 1, 1960
>> -Stat of file yields: -315593940
>> +Stat of file yields: -315615540
>> Remounting to flush cache
>> -Stat of file yields: -315593940
>> +Stat of file yields: -315615540
>>
>> Note that we still get the same for both, it just seems XFS rounds it
>> a bit different.
Hrm. Should we just test to be sure the timestamp is negative?
The sign extension is the real error, so as long as it's not
positive it's probably OK.
-Eric
>
> I haven't seen this one fail. Must have to do with
> some FS configuration options (like blocksize or
> something).
>
> -Alex
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-26 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 18:39 [PATCH] xfstests: test timestamps before the epoch Eric Sandeen
2011-09-22 16:48 ` Christoph Hellwig
2011-09-22 19:41 ` Alex Elder
2011-09-26 11:27 ` Christoph Hellwig
2011-09-26 12:27 ` Alex Elder
2011-09-26 16:02 ` Eric Sandeen [this message]
2011-09-26 17:09 ` Christoph Hellwig
2011-09-26 17:11 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80A1FD.8070400@redhat.com \
--to=sandeen@redhat.com \
--cc=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox