From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p9SDZZkq155079 for ; Fri, 28 Oct 2011 08:35:36 -0500 Message-ID: <4EAAAFA3.1070109@sgi.com> Date: Fri, 28 Oct 2011 08:35:31 -0500 From: Bill Kendall MIME-Version: 1.0 Subject: Re: [PATCH] xfsdump: fix metadata restore on split files References: <1319671483-27787-1-git-send-email-wkendall@sgi.com> <20111028093716.GA23069@infradead.org> In-Reply-To: <20111028093716.GA23069@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com Christoph Hellwig wrote: > On Wed, Oct 26, 2011 at 06:24:43PM -0500, Bill Kendall wrote: >> xfsrestore does not apply certain metadata until all of the file's >> data has been restored. This allows, for example, files with the >> immutable flag set to be restored properly. >> >> While testing multi-stream restores, I noticed that files split >> across multiple streams did not have their metadata restored. >> Looking into this further, it also applies to the single-stream >> case where files are split across media files, such as when a >> backup spans multiple tapes. >> >> The fix is to check to see if a file is completely restored >> whenever we hit the end of a media file. The current code >> is broken because it relies on all media files being applied >> during the same restore session. >> >> This also moves the S_ISREG() check into restore_complete_reg() >> rather than relying on callers to make the check. > > Uhh, that's a nasty bug for people storing large files over multiple > tapes. Any chance we could get an xfstests test case for this? > > Can we somehow simulate multiple tapes using small files? I'll look into this. Bill > > The code change looks okay to me, but I have to admit I don't really > understand the code very well. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs