public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Schmidt <mail@jan-o-sch.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org,
	Jan Schmidt <list.btrfs@jan-o-sch.net>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: check if qa user can execute commands
Date: Tue, 06 Dec 2011 16:16:45 +0100	[thread overview]
Message-ID: <4EDE31DD.3000401@jan-o-sch.net> (raw)
In-Reply-To: <20111206151300.GA11874@infradead.org>

On 06.12.2011 16:13, Christoph Hellwig wrote:
> On Tue, Dec 06, 2011 at 10:56:29AM +0100, Jan Schmidt wrote:
>> _require_user only checks if the qa user exists in /etc/passwd. It may exist
>> though still not be able to execute anything (e.g. with a /bin/false shell).
>>
>> _user_do cannot determine failure to execute the given command, as it uses
>> _user_do_filter for post-processing which succeeds even if the command
>> fails. Thus, the check should be performed by _require_user.
> 
> Looks good.  Wouldn't
> 
> 	su $qa_user -c /bin/true
> 
> be the more normal way to write that test?

I agree. I saw this and thought I'd adapt the (sometimes strange)
predominant bash programming style:

 921 _user_do()
 922 {
 923     if [ "$HOSTOS" == "IRIX" ]
 924         then
 925         echo $1 | /bin/bash "su $qa_user 2>&1" | _filter_user_do
 926     else
 927         echo $1 | su $qa_user 2>&1 | _filter_user_do
 928     fi
 929 }

-Jan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-12-06 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  9:56 [PATCH] xfstests: check if qa user can execute commands Jan Schmidt
2011-12-06 15:13 ` Christoph Hellwig
2011-12-06 15:16   ` Jan Schmidt [this message]
2011-12-06 15:18     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDE31DD.3000401@jan-o-sch.net \
    --to=mail@jan-o-sch.net \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=list.btrfs@jan-o-sch.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox