From: Mark Tinguely <tinguely@sgi.com>
To: jeff.liu@oracle.com
Cc: Christoph Hellwig <hch@infradead.org>,
Chris Mason <chris.mason@oracle.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add SEEK_DATA/SEEK_HOLE sanity checker
Date: Fri, 06 Jan 2012 09:54:29 -0600 [thread overview]
Message-ID: <4F071935.9050201@sgi.com> (raw)
In-Reply-To: <4EFB1C8D.8070405@oracle.com>
On 12/28/11 07:41, Jeff Liu wrote:
> +
> +static ssize_t do_pwrite(int fd, const void *buf, size_t count, off_t
> offset)
> +{
> + ssize_t ret, written = 0;
> +
> + while (count> written) {
> + ret = pwrite(fd, buf + written, count - written, offset
> + written);
>
I believe there is a missing "-" between "offset" and "written".
The patchworks version (3108) was truncated.
There are some line wraps on the patch file, which give patch/quilt errors.
Minor text editing.
--Mark Tinguely.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-01-06 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 13:41 [PATCH] xfstests: add SEEK_DATA/SEEK_HOLE sanity checker Jeff Liu
2012-01-06 15:54 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F071935.9050201@sgi.com \
--to=tinguely@sgi.com \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox