From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: mount other filesystems with selinux context as well
Date: Thu, 19 Jan 2012 12:37:48 -0600 [thread overview]
Message-ID: <4F1862FC.1050401@sandeen.net> (raw)
In-Reply-To: <20111128110228.GC13766@infradead.org>
On 11/28/11 5:02 AM, Christoph Hellwig wrote:
> On Wed, Nov 23, 2011 at 11:50:26AM -0600, Eric Sandeen wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> For some reason, non-xfs filesystems aren't getting mounted with
>> the selinux context; perhaps because none of the xattr tests used
>> to work on anything but xfs?
>>
>> Anyway, 062 fails for extN unless we mount with the fs-wide
>> context.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> - ---
>>
>> diff --git a/common.rc b/common.rc
>> index cab0b64..5998ff2 100644
>> - --- a/common.rc
>> +++ b/common.rc
>> @@ -86,14 +86,17 @@ _mount_opts()
>> export MOUNT_OPTIONS=$NFS_MOUNT_OPTIONS
>> ;;
>> ext2|ext3|ext4|ext4dev)
>> - - # acls & xattrs aren't turned on by default on ext$FOO
>> + export SELINUX_MOUNT_OPTIONS
>> + # acls & xattrs aren't turned on by default on ext$FOO in old kernels
>> export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>> ;;
>> reiserfs)
>> + export SELINUX_MOUNT_OPTIONS
>> # acls & xattrs aren't turned on by default on reiserfs
>> export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
>> ;;
>> gfs2)
>> + export SELINUX_MOUNT_OPTIONS
>> # acls aren't turned on by default on gfs2
>> export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
>> ;;
>
> shouldn't the "export SELINUX_MOUNT_OPTIONS" simply move to common code?
I wasn't sure if nfs would grok it.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-19 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 17:50 [PATCH] xfstests: mount other filesystems with selinux context as well Eric Sandeen
2011-11-28 11:02 ` Christoph Hellwig
2012-01-19 18:37 ` Eric Sandeen [this message]
2012-01-24 17:45 ` Christoph Hellwig
2012-01-25 21:11 ` [PATCH V2] " Eric Sandeen
2012-01-25 21:14 ` Christoph Hellwig
2012-01-25 21:28 ` Eric Sandeen
2012-01-27 11:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1862FC.1050401@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox