From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: James Lawrie <james@jdlawrie.co.uk>,
Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota
Date: Mon, 23 Jan 2012 23:07:35 -0600 [thread overview]
Message-ID: <4F1E3C97.1010503@sandeen.net> (raw)
In-Reply-To: <20120123195922.GA2366@infradead.org>
On 1/23/12 1:59 PM, Christoph Hellwig wrote:
> On Mon, Jan 23, 2012 at 11:31:53AM -0600, Eric Sandeen wrote:
>> Doing something like
>>
>> # xfs_quota -x -c 'limit -u bhard=1.2g ...
>>
>> will cause cvtnum to fail and return a value of -1LL (because it
>> cannot parse the decimal), but the quota caller doesn't check
>> for this error value, casts it to U64, shifts right, and we end
>> up with an answer of 16 petabytes rather than erroring out.
>> Fix this.
>
> Can you add a test case for it, please?
sure... I have quite a backlog of tests I need to get pushed to git :(
Is that an ack for the patch, though? :)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-24 5:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [PATCH] xfsprogs: check for size parsing errors in xfs_quota Eric Sandeen
2012-01-23 19:59 ` Christoph Hellwig
2012-01-24 5:07 ` Eric Sandeen [this message]
2012-01-24 17:56 ` Christoph Hellwig
2012-01-24 17:58 ` Eric Sandeen
2012-01-27 19:26 ` [PATCH V2] " Eric Sandeen
2012-02-03 17:41 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1E3C97.1010503@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=james@jdlawrie.co.uk \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox