Re: [PATCH V2] xfsprogs: check for size parsing errors in xfs_quota

Mark Tinguely
2012-02-03T17:41:11Z

On 01/27/12 13:26, Eric Sandeen wrote:
> Doing something like
>
> # xfs_quota -x -c 'limit -u bhard=1.2g ...
>
> will cause cvtnum to fail and return a value of -1LL (because it
> cannot parse the decimal), but the quota caller doesn't check
> for this error value, casts it to U64, shifts right, and we end
> up with an answer of 16 petabytes rather than erroring out.
> Fix this.
>
> Reported-by: James Lawrie<james@jdlawrie.co.uk>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

Looks and works great.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>