From: WuBo <wu.bo@cn.fujitsu.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: Question on xfstest 274
Date: Mon, 30 Jan 2012 10:43:24 +0800 [thread overview]
Message-ID: <4F2603CC.9080807@cn.fujitsu.com> (raw)
In-Reply-To: <4F230E62.8020004@sandeen.net>
On 01/28/2012 04:51 AM, Eric Sandeen wrote:
> Hi, I was wondering if you could describe your intent for 274 just a little more.
>
> The test says:
>
> # preallocation test
>
> but that is the only comment other than copyright. ;)
Maybe the comment is too simple :)
>
> I see that it does:
>
> # Make a 1G fs
> # Create a single 4k file
> # Allocate 1M past the EOF on that file
> # Completely fill remaining space, using 2 other files
> # Write 8k past EOF on the original file which has blocks past EOF
>
> but I am not certain what you are testing. I presume that
> you are testing the fact that the 1M past EOF should be truncated,
> freeing up space, and allowing the 8k write to succeed?
> Is that right?
Actually I write 8K at the end of 4K(seek=1), and what I want to test
is the 8K-write should be succeed because the preallocation 1M. At the
mean while, the file should not be truncated.
Thanks,
wubo
>
> However, at least on ext4 I noticed that the "fill the fs"
> stage does not succeed; perhaps that should be tested as well.
>
> I can do some similar work on this like I did for 275, but I need
> to be sure I understand your original intent for the test, first.
>
> Thanks,
> -Eric
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-30 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 20:51 Question on xfstest 274 Eric Sandeen
2012-01-30 2:43 ` WuBo [this message]
2012-01-30 21:22 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2603CC.9080807@cn.fujitsu.com \
--to=wu.bo@cn.fujitsu.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox