From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_io: deprecate the "-F" foreign flag
Date: Fri, 03 Feb 2012 10:10:40 -0600 [thread overview]
Message-ID: <4F2C0700.2030306@redhat.com> (raw)
In-Reply-To: <20120203150443.GA28301@infradead.org>
On 2/3/12 9:04 AM, Christoph Hellwig wrote:
> On Thu, Feb 02, 2012 at 11:35:04AM -0600, Eric Sandeen wrote:
>> There's no real reason to force the user to specify "-F" for non-xfs
>> files, when we can just test for that after it's opened.
>>
>> * Remove the -F flag from usage() & man pages, but still accept it.
>> * Set IO_FOREIGN when we open the file, if the fd tests as non-xfs.
>
> Looks good. We probably should kill the IO_FOREIGN eventually too, but
> let's do the user facing part first.
How would you want to handle non-xfs filesystems in the xfs-specific
commands? Do the fd test each time?
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, I'll merge it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-03 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 17:35 [PATCH] xfs_io: deprecate the "-F" foreign flag Eric Sandeen
2012-02-03 15:04 ` Christoph Hellwig
2012-02-03 16:10 ` Eric Sandeen [this message]
2012-02-13 19:00 ` Christoph Hellwig
2012-02-14 17:18 ` Eric Sandeen
2012-03-08 21:39 ` Mark Tinguely
2012-03-08 22:16 ` Eric Sandeen
2012-03-08 22:20 ` [PATCH] xfs_io: allow -F in open args Eric Sandeen
2012-03-08 22:37 ` Mark Tinguely
2012-03-08 22:37 ` Eric Sandeen
2012-03-08 22:39 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C0700.2030306@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox