From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: James Lawrie <james@jdlawrie.co.uk>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfsprogs: check for size parsing errors in xfs_quota
Date: Fri, 03 Feb 2012 11:41:11 -0600 [thread overview]
Message-ID: <4F2C1C37.60001@sgi.com> (raw)
In-Reply-To: <4F22FA5B.4030500@sandeen.net>
On 01/27/12 13:26, Eric Sandeen wrote:
> Doing something like
>
> # xfs_quota -x -c 'limit -u bhard=1.2g ...
>
> will cause cvtnum to fail and return a value of -1LL (because it
> cannot parse the decimal), but the quota caller doesn't check
> for this error value, casts it to U64, shifts right, and we end
> up with an answer of 16 petabytes rather than erroring out.
> Fix this.
>
> Reported-by: James Lawrie<james@jdlawrie.co.uk>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
Looks and works great.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-02-03 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [PATCH] xfsprogs: check for size parsing errors in xfs_quota Eric Sandeen
2012-01-23 19:59 ` Christoph Hellwig
2012-01-24 5:07 ` Eric Sandeen
2012-01-24 17:56 ` Christoph Hellwig
2012-01-24 17:58 ` Eric Sandeen
2012-01-27 19:26 ` [PATCH V2] " Eric Sandeen
2012-02-03 17:41 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C1C37.60001@sgi.com \
--to=tinguely@sgi.com \
--cc=james@jdlawrie.co.uk \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox