Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer

Kevan Rehm
2012-02-07T20:25:39Z

On 02/07/2012 12:38 PM, Christoph Hellwig wrote:
> On Sun, Nov 13, 2011 at 07:01:33AM -0500, Christoph Hellwig wrote:
>> On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:
>>> From: Kevan Rehm<kfr@sgi.com>
>>>
>>> In phase 6, in mk_root_dir(), xfs_repair initializes the mount
>>> point's m_rootip pointer without accounting for that reference.
>>> This field never really used or needed in repair otherwise, and the
>>> assigned pointer doesn't really represent a real reference to an
>>> inode that needs to be cached. So just kill off this assignment.
>>>
>>> Signed-off-by: Alex Elder<aelder@sgi.com>
>> Shouldn't this also have Kevan's signoff?
> Kevan, can you give me a signoff for this patch, I'd like to put it in?
>
Fine by me.

Kevan