Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer

Christoph Hellwig
2011-11-13T12:01:36Z

On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:
> From: Kevan Rehm <kfr@sgi.com>
>
> In phase 6, in mk_root_dir(), xfs_repair initializes the mount
> point's m_rootip pointer without accounting for that reference.
> This field never really used or needed in repair otherwise, and the
> assigned pointer doesn't really represent a real reference to an
> inode that needs to be cached. So just kill off this assignment.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>

Shouldn't this also have Kevan's signoff?

> ---
> repair/phase6.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index 1c82cb1..81d7fe6 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -797,8 +797,6 @@ mk_root_dir(xfs_mount_t *mp)
> ip->i_df.if_bytes = ip->i_df.if_real_bytes = 0;
> ip->i_df.if_u1.if_extents = NULL;
>
> - mp->m_rootip = ip;
> -

Looks good, but can we extent this a bit? The only reference to
mp->m_rootip in the userspace code is in libxfs_mount. By making
it a local variable there we can kill the field entirely.