Re: [PATCH 6/8] xfsprogs: xfs_db: unmount fs before exiting

Christoph Hellwig
2011-11-13T12:09:20Z

On Thu, Nov 10, 2011 at 02:35:16PM -0600, Alex Elder wrote:
> From: Kevan Rehm <kfr@sgi.com>
>
> The main routine calls libxfs_mount() via init(), but never calls
> libxfs_umount() at the end of the program so there could be
> filesystem changes queued which never get flushed to disk. This
> adds the missing libxfs_umount() call.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>