Re: [PATCH 5/8] xfsprogs: Drop root inode refrerence in libxfs_umount()

Christoph Hellwig
2011-11-13T12:07:06Z

On Thu, Nov 10, 2011 at 02:35:15PM -0600, Alex Elder wrote:
> From: Kevan Rehm <kfr@sgi.com>
>
> Routine libxfs_umount() did not call libxfs_iput for the m_rootip
> inode, so updates made to that inode could be lost. This adds the
> missing call, and re-initializes the m_rootip pointer to be null.
>
> Since the root inode reference is now dropped by libxfs_umount(), it
> should *not* be dropped in mkfs parseproto().

Looks fine in general, but as mentioned before live would be a lot
easier if we simply made the root inode a local variable in
libxfs_mount.

In fact I wonder if we even want to do that, there seems very little
reason to even do the root inode iget there - the only caller requesting
it will fall back if it fails.