Re: [PATCH 2/8] xfsprogs: unconditionally drop used buffer reference

Christoph Hellwig
2011-11-13T11:59:43Z

On Thu, Nov 10, 2011 at 02:35:12PM -0600, Alex Elder wrote:
> In libxfs_mount(), after reading the last block in the log device,
> the buffer is released by a call to libxfs_putbuf(). But it's done
> only if bp is non-null. It always will be non-null at this point,
> so just make the call unconditionally.
>
> Also touch up a misleading indent.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
> ---
> libxfs/init.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libxfs/init.c b/libxfs/init.c
> index 08fc584..ba44c9b 100644
> --- a/libxfs/init.c
> +++ b/libxfs/init.c
> @@ -743,15 +743,14 @@ libxfs_mount(
> if (!(flags & LIBXFS_MOUNT_DEBUGGER))
> return NULL;
> }
> - if (bp)
> - libxfs_putbuf(bp);
> + libxfs_putbuf(bp);
> }

This one isn't correct. If LIBXFS_MOUNT_DEBUGGER is set we still
get through to here.