Re: [PATCH v2 2/2] xfstests: introduce 280 for SEEK_DATA/SEEK_HOLE copy check

Jeff Liu
2012-05-15T04:47:47Z

Hi Rich,

Sorry for my late response!

On 05/11/2012 11:15 PM, Rich Johnston wrote:

>
> On 02/06/2012 08:30 AM, Jeff Liu wrote:
>> Introduce 280 for SEEK_DATA/SEEK_HOLE copy check.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>>
>
>
>
>> +static int
>> +do_extent_copy(int src_fd, int dest_fd, off_t data_off, off_t hole_off)
>> +{
>
> ...
>
>> +
>> + while (len> 0) {
>> + memset(buf, 0, sizeof(buf));
>> + ssize_t nr_read = read(src_fd, buf, BUF_SIZE);
> #RCJ The memset above is unnecessary.
>
>
>> +static int
>> +copy_extents(int src_fd, int dest_fd, off_t src_total_size)
>> +{
>> + int ret = 0;
>> + unsigned int i = 0;
>
> ...
>
>> + ++i;
>> + seek_start = hole_pos;
>> + } while (seek_start< src_total_size);
> #RCJ i is unused.

Thanks for the review, I'll fix them later.

-Jeff

>
> Other than the comments above, this version of the test looks good.
> Reviewed-by: Rich Johnston<rjohnston@sgi.com>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs