From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve
Date: Tue, 21 Feb 2012 09:18:04 -0600 [thread overview]
Message-ID: <4F43B5AC.9080500@sgi.com> (raw)
In-Reply-To: <20120220023154.252855704@bombadil.infradead.org>
On 02/19/12 20:31, Christoph Hellwig wrote:
> Split the log regrant case out of xfs_log_reserve into a separate function,
> and merge xlog_grant_log_space and xlog_regrant_write_log_space into their
> respective callers. Also replace the XFS_LOG_PERM_RESERV flag, which easily
> got misused before the previous cleanups with a simple boolean parameter.
>
> Reviewed-by: Ben Myers<bpm@sgi.com>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> ---
> fs/xfs/xfs_log.c | 198 ++++++++++++++++++++++++-----------------------------
> fs/xfs/xfs_log.h | 1
> fs/xfs/xfs_trace.h | 1
> fs/xfs/xfs_trans.c | 17 +++-
> 4 files changed, 103 insertions(+), 114 deletions(-)
Sorry for the omission. The clean up looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-21 15:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 2:31 [PATCH 00/12] log grant code cleanups V2 Christoph Hellwig
2012-02-20 2:31 ` [PATCH 01/12] xfs: split tail_lsn assignments from log space wakeups Christoph Hellwig
2012-02-20 2:31 ` [PATCH 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space Christoph Hellwig
2012-02-20 2:31 ` [PATCH 03/12] xfs: remove xfs_trans_unlocked_item Christoph Hellwig
2012-02-20 2:31 ` [PATCH 04/12] xfs: cleanup xfs_log_space_wake Christoph Hellwig
2012-02-20 2:31 ` [PATCH 05/12] xfs: remove log space waitqueues Christoph Hellwig
2012-02-20 2:31 ` [PATCH 06/12] xfs: add the xlog_grant_head structure Christoph Hellwig
2012-02-20 2:31 ` [PATCH 07/12] xfs: add xlog_grant_head_init Christoph Hellwig
2012-02-20 2:31 ` [PATCH 08/12] xfs: add xlog_grant_head_wake_all Christoph Hellwig
2012-02-20 2:31 ` [PATCH 09/12] xfs: share code for grant head waiting Christoph Hellwig
2012-02-20 2:31 ` [PATCH 10/12] xfs: share code for grant head wakeups Christoph Hellwig
2012-02-20 2:31 ` [PATCH 11/12] xfs: share code for grant head availability checks Christoph Hellwig
2012-02-20 2:31 ` [PATCH 12/12] xfs: split and cleanup xfs_log_reserve Christoph Hellwig
2012-02-21 15:18 ` Mark Tinguely [this message]
2012-02-21 4:56 ` [PATCH 00/12] log grant code cleanups V2 Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-12-12 14:13 [patch 00/12] log grant code cleanups Christoph Hellwig
2011-12-12 14:13 ` [patch 12/12] xfs: split and cleanup xfs_log_reserve Christoph Hellwig
2012-02-16 21:36 ` Ben Myers
2012-02-19 21:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F43B5AC.9080500@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox