public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
Date: Fri, 02 Mar 2012 14:15:49 -0600	[thread overview]
Message-ID: <4F512A75.9030300@sandeen.net> (raw)
In-Reply-To: <x49ipim7r19.fsf@segfault.boston.devel.redhat.com>

On 3/2/12 1:15 PM, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.
> 
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

Looks fine, I'll check it into xfstests-dev, thanks!

-Eric

> 
> diff --git a/113 b/113
> index 23676e0..b2ec510 100755
> --- a/113
> +++ b/113
> @@ -100,4 +100,10 @@ _do_test 2 "-s 10m" $count $procs
>  # as above, but now using direct IO
>  _do_test 3 "-s 10m -O" $count $procs
>  
> +# dio with O_SYNC and unwritten extent conversion
> +_do_test 4 "-s 10m -O -S" $count $procs
> +
> +# random dio writes with O_SYNC and unwritten extent conversion
> +_do_test 5 "-s 10m -O -S -o 2" $count $procs
> +
>  exit
> diff --git a/113.out b/113.out
> index 1f3b866..aa856a6 100644
> --- a/113.out
> +++ b/113.out
> @@ -12,3 +12,11 @@ aio-stress.2 : -t 20 -s 10m
>  -----------------------------------------------
>  aio-stress.3 : -t 20 -s 10m -O
>  -----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.4 : -t 20 -s 10m -O -S
> +-----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.5 : -t 20 -s 10m -O -S -o 2
> +-----------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-03-02 20:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 19:15 [xfstests patch] 113: add testing for O_DIRECT + O_SYNC Jeff Moyer
2012-03-02 20:15 ` Eric Sandeen [this message]
2012-03-03  9:33 ` Christoph Hellwig
2012-03-03 19:03   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F512A75.9030300@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=jmoyer@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox