Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

Eric Sandeen
2012-03-03T19:03:59Z

On 3/3/12 3:33 AM, Christoph Hellwig wrote:
> On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
>> Hi,
>>
>> This patch adds a couple more aio-stress runs to test 113. The first
>> simply adds -S, to test out AIO+DIO+O_SYNC. The second adds -S and -o
>> 2, which directs aio-stress to only perform the random write test.
>> These two tests helped identify several bugs in ext4.
>
> I'd rather make this a separate testcase, maybe moving the _do_test into
> common code.
>
> Rationale: newly added tests shouldn't make old testcases fail, as that
> would be rather confusing.

Well, phooey, I committed it already.

I can do another patch to revert & add to a new test if you really want.

-Eric

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs