Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

Christoph Hellwig
2012-03-03T09:33:38Z

On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
> Hi,
>
> This patch adds a couple more aio-stress runs to test 113. The first
> simply adds -S, to test out AIO+DIO+O_SYNC. The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.

I'd rather make this a separate testcase, maybe moving the _do_test into
common code.

Rationale: newly added tests shouldn't make old testcases fail, as that
would be rather confusing.