Re: [PATCH] xfstests: before test execution, print test number to syslog

Stefan Behrens
2012-03-02T15:27:25Z

On 3/2/2012 3:57 PM, Eric Sandeen wrote:
> On 3/2/12 6:26 AM, Stefan Behrens wrote:
>> When the xfstests are executed in a batch (like "check 001-299")
>> and produce syslog output, it is helpful to know which test was
>> causing the output. Therefore each time a test is started, a
>> syslog message is generated that contains the number of the
>> xfstest.
>>
>> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
>
> I like this; I almost sent a similar patch once.
>
> But would like to let others chime in as well to be sure.
>
> Is "logger" universal and portable to other systems? That'd be
> my only concern with the patch.

logger(1) is included in the POSIX specification.

>
> -Eric
>
>> ---
>> check | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/check b/check
>> index f792009..883edcc 100755
>> --- a/check
>> +++ b/check
>> @@ -241,6 +241,7 @@ do
>> start=`_wallclock`
>> $timestamp && echo -n " ["`date "+%T"`"]"
>> [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> + logger "run xfstest $seq"
>> ./$seq >$tmp.rawout 2>&1
>> sts=$?
>> $timestamp && _timestamp