Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes

Raghavendra D Prabhu
2012-06-01T06:07:11Z

[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]

Hi,

* On Thu, May 31, 2012 at 10:31:21PM -0500, Eric Sandeen <sandeen@sandeen.net> wrote:
>On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
>> Hi,
>>
>> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
>>
>> while (!agi->agi_freecount) {
>> }
>>
>> is redundant when noroom=1 and okalloc=0.
>>
>> Also, xfs_ialloc_ag_alloc function in the loop calls
>> ============
>> if (mp->m_maxicount &&
>> mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
>>
>> ===============
>>
>> condition again.
>>
>> So I have moved xfs_tran_brelse etc. into the condition along with message.
>>
>> Is this logic valid? If it is, then I will look into rate-limiting the message etc.
>
>It'd be easiest to understand this new change as a patch rather than as a description.
Yeah, I would certainly send it as a patch. This was just for RFC. :)

>
>If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.
Thanks, I will make it so.
>
>Thanks,