Re: [PATCH] Printk for ENOSPC due to lack of inodes

Eric Sandeen
2012-06-01T03:31:24Z

On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
> Hi,
>
> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
>
> while (!agi->agi_freecount) {
> }
>
> is redundant when noroom=1 and okalloc=0.
>
> Also, xfs_ialloc_ag_alloc function in the loop calls
> ============
> if (mp->m_maxicount &&
> mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
>
> ===============
>
> condition again.
>
> So I have moved xfs_tran_brelse etc. into the condition along with message.
>
> Is this logic valid? If it is, then I will look into rate-limiting the message etc.

It'd be easiest to understand this new change as a patch rather than as a description.

If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.

Thanks,

-eric