* [PATCH v2] xfstests: before test execution, print test number to syslog
@ 2012-03-05 17:26 Stefan Behrens
2012-03-05 21:35 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Behrens @ 2012-03-05 17:26 UTC (permalink / raw)
To: xfs
When the xfstests are executed in a batch (like "check 001-299")
and produce syslog output, it is helpful to know which test was
causing the output. Therefore each time a test is started, a
syslog message is generated that contains the number of the
xfstest.
Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
---
Changes v1->v2:
- In order to avoid noise, check that /usr/bin/logger is there
before trying to execute it. This usually should always be the
case except for embedded environments.
check | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/check b/check
index f792009..a4af0f6 100755
--- a/check
+++ b/check
@@ -241,6 +241,7 @@ do
start=`_wallclock`
$timestamp && echo -n " ["`date "+%T"`"]"
[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
+ [ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
./$seq >$tmp.rawout 2>&1
sts=$?
$timestamp && _timestamp
--
1.7.3.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] xfstests: before test execution, print test number to syslog
2012-03-05 17:26 [PATCH v2] xfstests: before test execution, print test number to syslog Stefan Behrens
@ 2012-03-05 21:35 ` Dave Chinner
2012-03-08 22:29 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2012-03-05 21:35 UTC (permalink / raw)
To: Stefan Behrens; +Cc: xfs
On Mon, Mar 05, 2012 at 06:26:09PM +0100, Stefan Behrens wrote:
> When the xfstests are executed in a batch (like "check 001-299")
> and produce syslog output, it is helpful to know which test was
> causing the output. Therefore each time a test is started, a
> syslog message is generated that contains the number of the
> xfstest.
>
> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
Looks ok.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] xfstests: before test execution, print test number to syslog
2012-03-05 21:35 ` Dave Chinner
@ 2012-03-08 22:29 ` Eric Sandeen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2012-03-08 22:29 UTC (permalink / raw)
To: Dave Chinner; +Cc: Stefan Behrens, xfs
On 3/5/12 3:35 PM, Dave Chinner wrote:
> On Mon, Mar 05, 2012 at 06:26:09PM +0100, Stefan Behrens wrote:
>> When the xfstests are executed in a batch (like "check 001-299")
>> and produce syslog output, it is helpful to know which test was
>> causing the output. Therefore each time a test is started, a
>> syslog message is generated that contains the number of the
>> xfstest.
>>
>> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
>
> Looks ok.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Thanks, I pushed this.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-08 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-05 17:26 [PATCH v2] xfstests: before test execution, print test number to syslog Stefan Behrens
2012-03-05 21:35 ` Dave Chinner
2012-03-08 22:29 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox