From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: xfstests - unchecked mount failures
Date: Fri, 09 Mar 2012 11:41:57 -0600 [thread overview]
Message-ID: <4F5A40E5.8080609@sandeen.net> (raw)
In-Reply-To: <20120309132828.GI4334@twin.jikos.cz>
On 3/9/12 7:28 AM, David Sterba wrote:
> Hi,
>
> I've encountered a bad situation when a failed mount in test 269 did not stop
> the test and continued to use the mount point and exhausted space on the root
> partition. A quick grep revealed that there are more tests with unchecked
> _scratch_mount calls.
>
> The underlying problem with failed mount was observed when the mount comes in a
> quick sequence after mount, I saw it with btrfs, and don't know if it affects
> other filesystems.
>
> So, either all callers should check the return value or _scratch_mount
> calls _fail. I'd go for the latter as it will make it more resilient
> against unintentional ommision of checking the retval in new tests and
> reviewer does not have keep that in mind.
Sounds good to me; _test_mount() should probably do the same?
I guess it'd be worth investigating exactly why it failed, though.
Still, if you'd like to send a patch to _fail in the mount helpers
if they fail, that sounds reasonable to me.
Thanks,
-Eric
>
> david
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-09 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 13:28 xfstests - unchecked mount failures David Sterba
2012-03-09 17:41 ` Eric Sandeen [this message]
2012-03-12 0:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A40E5.8080609@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox