From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: allow assigning the tail lsn with the AIL lock held
Date: Wed, 21 Mar 2012 12:22:17 -0500 [thread overview]
Message-ID: <4F6A0E49.4000606@sgi.com> (raw)
In-Reply-To: <20120316175636.373605151@bombadil.infradead.org>
On 03/16/12 12:55, Christoph Hellwig wrote:
> Provide a variant of xlog_assign_tail_lsn that has the AIL lock already
> held. By doing so we do an additional atomic_read + atomic_set under
> the lock, which comes down to two instructions.
>
> Switch xfs_trans_ail_update_bulk and xfs_trans_ail_delete_bulk to the
> new version to reduce the number of lock roundtrips, and prepare for
> a new addition that would require a third lock roundtrip in
> xfs_trans_ail_delete_bulk. This addition is also the reason for
> slightly rearranging the conditionals and relying on xfs_log_space_wake
> for checking that the filesystem has been shut down internally.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> ---
> fs/xfs/xfs_log.c | 31 +++++++++++++++++++++++--------
> fs/xfs/xfs_log.h | 1 +
> fs/xfs/xfs_trans_ail.c | 22 +++++++++++++++-------
> fs/xfs/xfs_trans_priv.h | 1 +
> 4 files changed, 40 insertions(+), 15 deletions(-)
>
> Index: xfs/fs/xfs/xfs_log.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log.c 2012-03-16 12:44:55.880363918 +0100
> +++ xfs/fs/xfs/xfs_log.c 2012-03-16 12:50:24.040370003 +0100
> @@ -915,27 +915,42 @@ xfs_log_need_covered(xfs_mount_t *mp)
> * We may be holding the log iclog lock upon entering this routine.
> */
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-21 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 17:55 [PATCH 0/4] implement filesystem freezing by emptying the AIL Christoph Hellwig
2012-03-16 17:55 ` [PATCH 1/4] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown Christoph Hellwig
2012-03-21 23:16 ` Dave Chinner
2012-03-16 17:55 ` [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush " Christoph Hellwig
2012-03-21 23:20 ` Dave Chinner
2012-03-24 13:47 ` Christoph Hellwig
2012-03-16 17:55 ` [PATCH 3/4] xfs: allow assigning the tail lsn with the AIL lock held Christoph Hellwig
2012-03-21 17:22 ` Mark Tinguely [this message]
2012-03-21 23:29 ` Dave Chinner
2012-03-24 13:48 ` Christoph Hellwig
2012-03-16 17:55 ` [PATCH 4/4] xfs: implement freezing by emptying the AIL Christoph Hellwig
2012-03-21 23:57 ` Dave Chinner
2012-03-24 17:06 ` Christoph Hellwig
2012-03-24 17:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A0E49.4000606@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox