From: Eric Sandeen <sandeen@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Eryu Guan <eguan@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 235: do smaller test IO
Date: Mon, 26 Mar 2012 17:21:12 -0500 [thread overview]
Message-ID: <4F70EBD8.9030006@redhat.com> (raw)
In-Reply-To: <20120326220926.GO5091@dastard>
On 3/26/12 5:09 PM, Dave Chinner wrote:
> On Mon, Mar 26, 2012 at 02:30:33PM -0500, Eric Sandeen wrote:
>> Test 235 fails on ext2/ext3 with 1024 fs block size because a
>> 16k write uses an extra metadata block. If we do a smaller write
>> this won't happen.
> .....
>>
>> -$XFS_IO_PROG -F -c 'pwrite 0 16k' -c 'fsync' \
>> +$XFS_IO_PROG -F -c 'pwrite 0 8k' -c 'fsync' \
>
> So now it fails only on 512 byte block size filesystems?
ext[23] don't do 512 byte block filesystems, so no. ;)
> Perhaps rather than an exact match, a "within_tolerance" match could
> be done on the relevant fields?
>
> i.e something like:
>
> blksused=`{requota cmd} | awk '/fsgqa/ { print $3 }'`
> _within_tolerance "blocks used" $blksused 16 1
>
> If you wanted to get really fancy, the tolerance could be set
> depending on filesystem type and block size, but I don't think that
> is really necessary....
But I don't want to get really fancy, I spend enough time in xfstests
already. ;)
TBH even the _within_tolerance will take more munging around to get right,
it doesn't seem worth it, but if it's required for a review, ok...
-Eric
> Cheers,
>
> Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-26 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 19:30 [PATCH] xfstests 235: do smaller test IO Eric Sandeen
2012-03-26 22:09 ` Dave Chinner
2012-03-26 22:21 ` Eric Sandeen [this message]
2012-03-27 1:18 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70EBD8.9030006@redhat.com \
--to=sandeen@redhat.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox