From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] 030: fix for new xfs_repair versions
Date: Mon, 02 Apr 2012 09:35:10 -0500 [thread overview]
Message-ID: <4F79B91E.3060008@sgi.com> (raw)
In-Reply-To: <20120331232836.GA19572@infradead.org>
On 03/31/12 18:28, Christoph Hellwig wrote:
> Given that we now drop invalid unlinked inode lists there is no message
> to capture. Also add a sed expression to avoid failures on old repair
> versions.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> Index: xfstests-dev/030
> ===================================================================
> --- xfstests-dev.orig/030 2012-03-31 23:15:11.000000000 +0000
> +++ xfstests-dev/030 2012-03-31 23:18:31.000000000 +0000
> @@ -55,7 +55,8 @@ _check_ag()
> for structure in 'sb 0' 'agf 0' 'agi 0' 'agfl 0'
> do
> echo "Corrupting $structure - setting bits to $1"
> - _check_repair $1 "$structure"
> + _check_repair $1 "$structure" |
> + sed -e 's/error following ag 0 unlinked list//'
> done
> }
>
> @@ -97,8 +98,7 @@ src/devzero -v -1 -n "$clear" $SCRATCH_D
>
> # now kick off the real repair test...
> #
> -_scratch_mkfs_xfs $DSIZE | _filter_mkfs | \
> - sed -e 's/error following ag 0 unlinked list//' 2>$tmp.mkfs
> +_scratch_mkfs_xfs $DSIZE | _filter_mkfs 2>$tmp.mkfs
> . $tmp.mkfs
> _check_ag 0
> _check_ag -1
> Index: xfstests-dev/030.out.linux
> ===================================================================
> --- xfstests-dev.orig/030.out.linux 2012-03-31 23:19:09.000000000 +0000
> +++ xfstests-dev/030.out.linux 2012-03-31 23:19:17.000000000 +0000
> @@ -85,7 +85,6 @@ bad agbno AGBNO for inobt root, agno 0
> root inode chunk not found
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
> -error following ag 0 unlinked list
> - process known inodes and perform inode discovery...
> - process newly discovered inodes...
> Phase 4 - check for duplicate blocks...
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
The sed left a blank line where where the "error following ag 0 unlinked
list" would have been in an 3.0.x kernel run of the test.
Maybe add another "sed -e '/^$/d'" to the filter?
--Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-02 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 23:28 [PATCH] 030: fix for new xfs_repair versions Christoph Hellwig
2012-04-02 14:35 ` Mark Tinguely [this message]
2012-04-10 18:56 ` Mark Tinguely
2012-05-23 13:12 ` Mark Tinguely
2012-05-23 13:55 ` Christoph Hellwig
2012-05-23 17:11 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79B91E.3060008@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox