From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	q35JC6FB064371 for <xfs@oss.sgi.com>; Thu, 5 Apr 2012 14:12:06 -0500
Message-ID: <4F7DEE83.5050106@sgi.com>
Date: Thu, 05 Apr 2012 14:12:03 -0500
From: Mark Tinguely <tinguely@sgi.com>
MIME-Version: 1.0
Subject: Re: [PATCH 1/2] xfs: merge xfs_itobp into xfs_imap_to_bp
References: <20120329232543.GA30033@infradead.org>
In-Reply-To: <20120329232543.GA30033@infradead.org>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com

On 03/29/12 18:25, Christoph Hellwig wrote:
> All callers of xfs_imap_to_bp want the dinode pointer, so let's calculate it
> inside xfs_imap_to_bp.  Once that is done xfs_itobp becomes a fairly pointless
> wrapper which can be replaced with direct calls to xfs_imap_to_bp.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs