From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: several 274 fixups
Date: Fri, 06 Apr 2012 11:12:08 -0500 [thread overview]
Message-ID: <4F7F15D8.9050807@sgi.com> (raw)
In-Reply-To: <4F593147.8050603@sandeen.net>
On 03/08/12 16:23, Eric Sandeen wrote:
> This changes quite a few things about 274 to make it more robust
> and useful.
>
> * More comments
> * Use xfs_io for falloc (not all systems have /usr/bin/fallocate)
> * use _require_xfs_io_falloc to be sure system& fs support preallocation
> * Do not remove all of the files in $SCRATCH_MNT/ post-mkfs
> * Do not remove all of the files in $SCRATCH_MNT/ on completion
> (this breaks e2fsck when lost+found/ goes missing)
> * Don't cd into $SCRATCH_MNT
> * Try harder to completely fill the fs
> * Use a larger preallocated space, and write into all of it (hopefully
> avoid just accidentally succeeding by writing into fs reserved
> space that may be there)
> * Save more output in $seq.full instead of /dev/null
> * Fill preallocated space diabolically
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
Looks very nice.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-06 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 22:27 [PATCH] xfstests: several 274 fixups Eric Sandeen
2012-01-31 22:41 ` Dave Chinner
2012-02-01 2:27 ` Eric Sandeen
2012-02-01 4:07 ` Dave Chinner
2012-03-08 21:55 ` Eric Sandeen
2012-03-08 23:34 ` Dave Chinner
2012-03-08 22:23 ` [PATCH V2] " Eric Sandeen
2012-04-06 16:12 ` Mark Tinguely [this message]
2012-03-31 16:00 ` [PATCH] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F15D8.9050807@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox