From: Bryan Schumaker <bjschuma@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set
Date: Wed, 11 Apr 2012 16:10:12 -0400 [thread overview]
Message-ID: <4F85E524.1090107@netapp.com> (raw)
In-Reply-To: <20120411200433.GE28816@infradead.org>
On 04/11/12 16:04, Christoph Hellwig wrote:
> On Tue, Apr 10, 2012 at 07:44:45AM +1000, Dave Chinner wrote:
>> On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote:
>>> The cleanup function is trapped before _require_scratch() is called, and
>>> then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*"
>>
>> It doesn't need to clean up the scratch device - tests need to mkfs
>> it first before using it, so just remove the $tmp* files. The sae
>> fix is needed for tests 274 and 275.
>
> Given his address I assume Bryan might test on NFS, which has funky
> semantics for the scratch device.
>
> Is that true Bryan? I really need to dive back into how we handle NFS
> in this respect to have a good judgement on this patch.
>
Yeah, I'm testing on NFS (I guess the netapp address is a bit of a giveaway...). I don't think this test runs on NFS, but if the scratch variables are unset then it'll still delete the root directory of the NFS client.
- Bryan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-04-11 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 18:36 [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set Bryan Schumaker
2012-04-09 21:44 ` Dave Chinner
2012-04-10 13:09 ` Bryan Schumaker
2012-04-11 7:24 ` Lukas Czerner
2012-04-11 20:04 ` Christoph Hellwig
2012-04-11 20:10 ` Bryan Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85E524.1090107@netapp.com \
--to=bjschuma@netapp.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox