Re: [PATCH 02/10] xfs: remove log item from AIL in xfs_iflush after a shutdown

Dave Chinner
2012-04-13T09:37:16Z

On Tue, Mar 27, 2012 at 12:44:02PM -0400, Christoph Hellwig wrote:
> If a filesystem has been forced shutdown we are never going to write inodes
> to disk, which means the inode items will stay in the AIL until we free
> the inode. Currently that is not a problem, but a pending change requires us
> to empty the AIL before shutting down the filesystem. In that case leaving
> the inode in the AIL is lethal. Make sure to remove the log item from the AIL
> to allow emptying the AIL on shutdown filesystems.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Simplifies things a lot - abort immediately rather than leave it for
someone else to cleanup.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com