Re: [PATCH 05/10] xfs: do flush inodes from background inode reclaim

Mark Tinguely
2012-04-16T19:25:14Z

On 03/27/12 11:44, Christoph Hellwig wrote:
> We already flush dirty inodes throug the AIL regularly, there is no reason
> to have second thread compete with it and disturb the I/O pattern. We still
> do write inodes when doing a synchronous reclaim from the shrinker or during
> unmount for now.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> ---

> - */
> - return 0;
> + xfs_iflock(ip);
>
> reclaim:
> xfs_ifunlock(ip);

Is this flush lock / flush unlock cycle needed?

Reviewed-by: Mark Tinguely <tinguely@sgi.com>