Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes

Dave Chinner
2012-04-30T02:46:22Z

On Sun, Apr 29, 2012 at 05:55:25PM -0400, Christoph Hellwig wrote:
> > * Visible inode allocation functions.
> > */
> > +/*
> > + * Find a free (set) bit in the inode bitmask.
> > + */
> > +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> > +{
> > + return xfs_lowbit64(*fp);
> > +}
>
> I'd suggest killing this helper entirely - there is just a single
> caller, and using the lowbit helper directly actually is even more
> obvious.

Ok. Done.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com